Repository navigation
feat: Support passing kwargs to polars.scan_iceberg in Table.to_polars - #3868
Open
hedger9487 wants to merge 1 commit into
Open
hedger9487 wants to merge 1 commit into
hedger9487 wants to merge 1 commit into
Conversation
hedger9487
force-pushed
the
feat/table-to-polars-kwargs-3128
branch
2 times, most recently
from
August 27, 2026 09:41
7f9e959 to
2696f07
Compare
Fokko
approved these changes
Sep 7, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
API wise there is now harm in allowing this 👍 Thanks @hedger9487
Fokko
enabled auto-merge
September 7, 2026 09:04
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
auto-merge was automatically disabled
October 8, 2026 17:30
Head branch was pushed to by a user without write access
hedger9487
force-pushed
the
feat/table-to-polars-kwargs-3128
branch
from
October 8, 2026 17:30
2696f07 to
be3cd92
Compare
Contributor
Author
|
Rebased onto latest |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3128
Rationale for this change
Currently,
Table.to_polars()does not accept keyword arguments and callspolars.scan_iceberg(self)directly without forwarding options. This prevents users from passing crucial scan configurations such asstorage_options(cloud credentials for S3/GCS/Azure),snapshot_id(time-travel queries), orreader_override.This change updates
Table.to_polars()to accept**kwargs: Anyand forward them topolars.scan_iceberg(self, **kwargs).Are these changes tested?
Yes, tested with:
tests/table/test_init.py::test_table_to_polars_forwards_kwargs: Unit test verifying exact forwarding of keyword arguments (both empty and populated) matching the convention of other engine bridges (to_daft,to_bodo,to_ray).tests/table/test_init.pyand 468 tests intests/table/pass cleanly.uv run prek run -a) pass 100%.Are there any user-facing changes?
Yes,
Table.to_polars()now accepts**kwargsforwarded topolars.scan_iceberg, enabling users to supplystorage_options,snapshot_id,reader_override, etc.