Repository navigation
Conversation
SigV4Adapter is mounted on the catalog URI and overrides the timeout adapter, so rest.client.*-timeout-ms was ignored when rest.sigv4-enabled is set.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4076
Rationale for this change
rest.client.connection-timeout-msandrest.client.socket-timeout-msare ignored whenrest.sigv4-enabledis set.SigV4Adapteris mounted on the catalog URI, which is a longer prefix than thehttp:///https://timeout adapter, sorequestsalways picks it, and it never sets a timeout.SigV4Adapternow extends_RetryTimeoutHTTPAdapterand receives the same timeout, computed by a new shared helper_connection_timeout(). It keeps usingrest.sigv4.max-retriesfor retries. The SigV4 retry behaviour (10 retries, no backoff) is unchanged and tracked in #3008.Are these changes tested?
Yes,
test_sigv4_adapter_applies_client_timeoutintests/catalog/test_rest.py.Are there any user-facing changes?
Yes: the
rest.client.*timeouts now take effect for SigV4-signed catalogs (e.g. S3 Tables, Glue REST). Documented inconfiguration.md.