Repository navigation
fix(pr-management): keep code-review save names within the vetted-ops limit - #1917
Merged
Merged
Conversation
… limit `code-review reviewers` asks for a `cr-path-commits` read saved as `path-commits-<slug>.json`, with the slug cut at 90 characters. With the prefix and suffix that reaches 108, and vetted-ops refuses any save name over 100, so for a deeply nested file (the security-tools plugin mirror, for one) the read could never be saved and the reviewer ranking stayed incomplete. A cut alone would also let two long paths that share a stem read each other's commits. A path whose slug is over 80 characters now keeps a 70-character stem and an 8-character hash of the whole path. Tests hold the save name to the vetted-ops rule and check that long paths stay distinct. Generated-by: Claude Opus 5
github-actions
Bot
added
family:tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code-review reviewersasks for acr-path-commitsread saved aspath-commits-<slug>.json, with the slug cut at 90 characters.With the prefix and suffix that reaches 108, and vetted-ops refuses any save name over 100,
so for a deeply nested file (the
plugins/magpie-security-tools/mirror, for one) the read could never be saved and the reviewer ranking stayed incomplete.It came up reviewing #1911.
A cut alone would also let two long paths that share a stem read each other's saved commits.
A path whose slug is over 80 characters now keeps a 70-character stem and an 8-character hash of the whole path.
Tests hold the save name to the vetted-ops rule and check that long paths stay distinct.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 5) following the guidelines
🤖 Generated with Claude Code