Repository navigation
[TEST] Skip the flaky shared DAG hash scaling test - #857
Merged
tqchen merged 1 commit intoOct 19, 2026
Merged
Conversation
cyx-6
force-pushed
the
2026-10-19/robust-dag-hash-scaling-test
branch
from
October 18, 2026 16:37
da227f6 to
fe42c90
Compare
cyx-6
changed the title
test_shared_dag_hash_scaling_not_exponential compares the mean time of hashing depth-18 and depth-19 shared DAGs against a 10x ratio. Each hash takes a few microseconds, so a single scheduling stall pushes the ratio past the threshold: it failed the aarch64 wheel job of the v0.1.13, v0.1.14-post1 and v0.1.15 Publish wheel runs, and mainline-only CI. Every failure holds the whole PyPI upload until the job is re-run. Skip it until it can be made robust.
cyx-6
force-pushed
the
2026-10-19/robust-dag-hash-scaling-test
branch
from
October 19, 2026 09:08
fe42c90 to
893f411
Compare
cyx-6
changed the title
tqchen
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
test_shared_dag_hash_scaling_not_exponentialcompares the mean time of hashing depth-18 and depth-19 shared DAGs against a 10x ratio. Each hash takes a few microseconds, so a single scheduling stall pushes the ratio past the threshold. It failed the aarch64 wheel job of the Publish wheel runs for v0.1.13, v0.1.14-post1 (twice) and v0.1.15 (d18=0.000006s d19=0.000155s), and mainline-only CI on cp315. Every failure holds the whole PyPI upload until the job is re-run. #612 and #702 already relaxed its threshold.What changed
Skip the test with
@pytest.mark.skip, giving the reason.Validation
tests/python/test_dataclass_hash.py:152 passed, 1 skipped; the skip reason is reported.ruff checkandruff format --checkpass.check version consistencycurrently fails on every PR becausemainstill has patch 15 after thev0.1.15tag; chore(release): Version bump after release v0.1.15 #856 fixes that.