Skip to content

fix: stabilize image accumulation screen - #57

Merged
kgofron merged 1 commit into
areaDetector:masterfrom
kgofron:fix/image-accumulation-screen-stability
Sep 29, 2026
Merged

kgofron merged 1 commit into
areaDetector:masterfrom
kgofron:fix/image-accumulation-screen-stability

Conversation

@kgofron

@kgofron kgofron commented Sep 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace nine overlapping, geometry-specific Image Accumulation widgets with three dynamically sized widgets:
    • accumulated image;
    • current frame;
    • sum of the last N frames.
  • Select image width, height, axis limits, and widget height from PixCount_RBV.
  • Preserve support for:
    • 256×256;
    • 512×512;
    • 1024×512 detector rasters.
  • Add the screen-stability correction to the R1-8-0 release notes.

The previous overlapping widgets could cause Phoebus ArrayIndexOutOfBoundsException warnings when the screen opened and periodically during acquisition.

No PV names, accumulation controls, driver behavior, database records, or NDArray addresses are changed.

Runtime qualification

The screen was tested in the SNS Phoebus environment:

  • it opened without the previous array-index warnings;
  • accumulated, current-frame, and last-N images updated correctly;
  • acquisition did not produce the previous periodic warnings;
  • the copied driver screen is byte-identical to the tested SNS BOB file.

Validation

  • 346/346 deterministic tests passed.
  • 11 implemented coordinate-map cases passed; five planned physical SpIDR 2×4 cases remain deferred.
  • 47/47 Phoebus BOB files passed XML validation.
  • REUSE validation passed for 377/377 files.
  • git diff --check passed.

Hosted CI passed in the fork on commit 483e5be:

  • clean EPICS Base 7.0/asyn/ADCore build;
  • 346/346 deterministic tests;
  • coordinate-map and BOB XML validation;
  • REUSE compliance;
  • TAP artifact collection.

Run: https://github.com/kgofron/ADTimePix3/actions/runs/36509485831

@kgofron
kgofron merged commit a40b0b4 into areaDetector:master Sep 29, 2026
1 check passed
@kgofron
kgofron deleted the fix/image-accumulation-screen-stability branch September 29, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant