Repository navigation
fix: size eight-chip profile and waveform capacity - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MASK_BPC_NELEMENTS=524288to reserve complete 1024×512 record capacity for mask/BPC, PixelConfig-difference, and image-accumulation waveforms.NELMTstartup setting.No driver source, PV names, IOC databases, NDArray addresses, or Phoebus screens are changed.
Runtime qualification
SNS Phoebus testing with the 1024×512 two-quad detector passed:
Eight-chip mask/BPC qualification remains pending:
rowsCols()currently derives a 128-pixel chip for the 4×2 layout, causingRefreshPixelConfigto expect 16384 rather than 65536 bytes per chip.Rectangular mask geometry and deterministic two-quad calibration composition will be handled separately.
Validation
git diff --checkpassed.Hosted CI should confirm the default, AddressSanitizer, and UndefinedBehaviorSanitizer jobs.