Repository navigation
Merge upstream PrismarineJS/node-minecraft-protocol master (#1549) into iongolem (2026-10-25) - #1
Merged
Merged
Conversation
26.1 introduced the ItemStackTemplate type (used by SlotComponent, Particle, SlotDisplay and advancements), and packetTest had no value for it, failing with 'No value for type ItemStackTemplate'. Claude-Session: https://claude.ai/code/session_01MY5J9XTnWK8ZsJTmxvi7vF Co-authored-by: Claude <noreply@anthropic.com>
…26-10-25 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
arielvino
added a commit
to arielvino/ion-golem
that referenced
this pull request
Oct 25, 2026
Lockfile bump for the 2026-10-25 upstream merges into the forks' `iongolem` branches. The diff moves only these two pins. - **mineflayer** `eae111f` → `1bb09ce` (arielvino/mineflayer#18): - upstream #4062: reads the 1.21.2+ `entity_teleport` layout - #4112: reads the 1.20.3+ scoreboard packets - #4108: a teleport no longer changes the standing flag - **minecraft-protocol** `c762511` → `eae8e29` (arielvino/node-minecraft-protocol#1): upstream #1549, test-only. Checks: - `npm test`: 294/294 pass. - A quiet bot joins the cave box on 26.3. - With an entity teleported by command, the bot sees it at the target (pig to 28.5,121,25.5). The minecraft-data bump follows in a second commit here once arielvino/node-minecraft-data#4 is merged. That PR only adds version listings (26.4 snapshots) and docs/CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges
PrismarineJS/node-minecraft-protocolmasterintoiongolem(git merge --no-ff).Upstream commits brought in
test/packetTest.js.Conflicts
None. The merge was clean.
Tests
standard test/packetTest.js: passes.mocha test/packetTest.js: with theminecraft-datafrom npm thatpackage.jsonpins (^3.109.0), the file fails to load because that release has no 26.2/26.3 data. I swapped ingithub:arielvino/node-minecraft-data#iongolemlocally, insidenode_modulesonly:iongolembefore the merge: 5591 passing, 73 failingpacket_advancementson 26.1, 26.2 and 26.3 ("No value for type ItemStackTemplate").packets 26.3vand fail the same way before the merge, e.g.packet_sync_entity_position: Cannot convert undefined or null to object. They are not caused by this merge.🤖 Generated with Claude Code