Repository navigation
feat: use semver with floating major tag - #152
Open
reedham-aws wants to merge 2 commits into
Open
reedham-aws wants to merge 2 commits into
reedham-aws wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#112, #151
Description
Previously, this repository had been using a floating major tag and had been force pushing that tag for every new commit. This a) didn't follow the principles of semantic versioning (because there was only ever major releases) and b) didn't allow for immutable releases. This commit changes this by creating a new release for a specific version every time a semver tag is pushed. To maintain the floating tag if a user wants the latest version, we still move around the
v<major version>tag.I've also enabled immutable releases in the settings of the repository.
In #112, it's suggested by @roger-zhangg to use versioning based off of SAM CLI's version, but I opted against that here because of the ability to pin a SAM CLI version like so:
Without the version specified, the version will update to latest regardless.
Checklist
npm run allBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 License.