Repository navigation
forward checksum configuration to get object in crt client - #3950
Merged
Merged
Conversation
sbiscigl
marked this pull request as ready for review
October 5, 2026 17:29
sbaluja
approved these changes
Oct 5, 2026
pulimsr
approved these changes
Oct 5, 2026
DmitriyMusatkin
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
S3Crt
GetObjectnever properly forwarded theResponseChecksumValidationon the get object request. this fixes that by forwarding it in the checksum configuration.Tested locally with a mock server to mimick a bad checksum as its not possible via mocks with CRT in tests.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.