Skip to content

fix(WL-572): change locale and dynamic strings when setLocale is called - #31

Merged
nayaradias merged 1 commit into
mainfrom
fix/WL-572
Oct 5, 2026
Merged

nayaradias merged 1 commit into
mainfrom
fix/WL-572

Conversation

@DanielAraldi

Copy link
Copy Markdown
Contributor

📝 Summary

Fixes setLocale on Android, which did not change the Aziface SDK language on physical devices, even when the change was forced.


✅ Checklist

Mark the items that have been completed in this PR:

⚠️ Impact

  • Low (isolated change)
  • Medium (affects multiple areas)
  • High (critical flow/risk of regression)

📱 React Native

--

🤖 Android

  • AzifaceMobileModule.setupI18n() now creates localized resources with createConfigurationContext instead of mutating the app/base context configuration with updateConfiguration.
  • DynamicStrings accepts a Resources instance (setResources) and, on build(), fills every null string with the localized value before calling FaceTecSDK.setDynamicStrings().
  • Localization.getLocale() now returns a java.util.Locale (Locale.forLanguageTag), and pt-BR is mapped to pt-BR (resolves values-pt-rBR) instead of pt.
  • Removed unused imports (DisplayMetrics, Locale) from AzifaceMobileModule.

🍎 iOS

--


🧪 Testing Notes

  1. Set the device language to a language different from the one being tested (e.g., English).
  2. In the example app, call setLocale('es') (or any other supported locale, including pt-BR).
  3. Start a session (liveness, enroll, authenticate, photoIDMatch, or photoIDScanOnly) and check that every FaceTec screen is shown in the selected language.
  4. Call setDynamicStrings with a partial set of strings and check that the customized strings are shown, while the remaining ones follow the selected locale.
  5. Call resetDynamicStrings / setLocale('default') and check that the SDK goes back to the default strings (English).
  • Tested on Android (device/emulator)
  • Tested on iOS (simulator/device)
  • Automated tests added/updated
  • QA passed

🔗 Related Issues / Tickets

Link any related Jira tickets, GitHub issues, or Trello cards:

  • Closes #WL-572

📸 Evidence (Optional)

Attach any visual evidence of the changes (e.g., screenshots, GIFs, videos, or external links):

--


⚠️ Notes for Reviewers (Optional)

--

@DanielAraldi DanielAraldi self-assigned this Oct 1, 2026
@DanielAraldi DanielAraldi added bug Something isn't working android Android only i18n Internationalization changes labels Oct 1, 2026
@DanielAraldi
DanielAraldi enabled auto-merge (squash) October 5, 2026 12:56
@nayaradias
nayaradias disabled auto-merge October 5, 2026 14:38
@nayaradias
nayaradias merged commit 7cec5a3 into main Oct 5, 2026
1 of 2 checks passed
@nayaradias
nayaradias deleted the fix/WL-572 branch October 5, 2026 14:38
@nayaradias

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.8.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nayaradias nayaradias added the released Version released label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android Android only bug Something isn't working i18n Internationalization changes released Version released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants