Repository navigation
Conversation
Collaborator
🟡 Heimdall Review Status
|
Keep master's Sepolia AggregateVerifier (0xd702aaE6, now gameImpls(621)) and the FaultDisputeGame (Kona) row: 0x6dDBa09b is registered for both game type 0 and game type 8, so that row is not a duplicate.
Take master's mainnet AggregateVerifier from base#2030 (0xeF9eCeA1, now gameImpls(621)).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
One row on
specifications/reference/base-contractsno longer matches what is on chain:0x6CDEbe94…3E47→0xfc56E727…8bA3. SepoliaSystemConfig.batcherHash()returns0xfc56e727…, and that is the only address posting to the0xff…84532batch inbox right now.Notes to reviewers
The mainnet AggregateVerifier change this PR used to carry is now in master via #2030 (
0xeF9eCeA1…, which is whatgameImpls(621)returns today), so it was dropped in the merge.It is a read-only
eth_callyou can repeat:Rebased on master after #2003. The Sepolia AggregateVerifier from #2003 (
0xd702aaE6…) already matchesgameImpls(621), so it is untouched. An earlier revision also removed the SepoliaFaultDisputeGame (Kona)row as a duplicate; that was wrong,0x6dDBa09b…is registered for both game type 0 and game type 8, so the row stays.The mainnet Batch Sender (
0x5050f69a…) already matchesbatcherHash(). I leftSystemDictatorand the mainnet legacyOptimismMintableERC20Factoryalone since those are judgement calls rather than wrong values.How has it been tested?
node scripts/lint-mdx.js docs/specifications/reference/base-contracts.mdxandnode scripts/validate-docs-structure.jspass.Screenshots
N/A (table cell edits only)