Skip to content

Revert "Update SDK to 3.0.0-8157-eb825d59" - #7247

Closed
LRNcardozoWDF wants to merge 1 commit into
mainfrom
revert-7217-sdlc/sdk-update
Closed

LRNcardozoWDF wants to merge 1 commit into
mainfrom
revert-7217-sdlc/sdk-update

Conversation

@LRNcardozoWDF

Copy link
Copy Markdown
Member

Reverts #7217

@LRNcardozoWDF
LRNcardozoWDF requested review from a team and david-livefront as code owners August 6, 2026 15:04
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context labels Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This is a clean revert of PR 7217, rolling the Bitwarden SDK back from 3.0.0-8157-eb825d59 to 3.0.0-8144-cf7ad654 and removing the three WebAuthnPrfUnlockData no-op overrides (plus their tests) that the newer SDK's StateBridgeForeignImpl interface required. The change is exactly inverse to the original commit across the same three files, and a repository-wide search confirms no remaining WebAuthnPrf references that would break compilation against the older SDK. No lock or dependency-verification files exist for this manifest, so nothing else needs to be kept in sync.

Code Review Details

No code findings.

The SDK version downgrade is intentional and is the entire purpose of this PR, so it is not flagged as a finding. Worth confirming the follow-up plan so the reverted SDK changes (KDF changes, blob-encryption fix, flight recorder level) are re-landed once the underlying problem is resolved.

Dependency Changes

Package Change Ecosystem
bitwardenSdk 3.0.0-8157-eb825d59 → 3.0.0-8144-cf7ad654 (revert) Gradle

PR Metadata Assessment

  • ❓ QUESTION: The Enforce Label check is failing because no Change Type (t:*) label is present. Adding one (or ignore-for-release) will unblock CI.

@codecov

codecov Bot commented Aug 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.82%. Comparing base (32c2e8a) to head (b705119).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7247      +/-   ##
==========================================
- Coverage   86.11%   85.82%   -0.29%     
==========================================
  Files         894      895       +1     
  Lines       65210    65425     +215     
  Branches     9756     9757       +1     
==========================================
- Hits        56155    56154       -1     
- Misses       5560     5776     +216     
  Partials     3495     3495              
Flag Coverage Δ
app-data 17.81% <ø> (-0.01%) ⬇️
app-ui-auth-tools 18.67% <ø> (+<0.01%) ⬆️
app-ui-platform 16.46% <ø> (+<0.01%) ⬆️
app-ui-vault 27.40% <ø> (+<0.01%) ⬆️
authenticator 6.06% <ø> (-0.01%) ⬇️
lib-core-network-bridge 4.09% <ø> (-0.02%) ⬇️
lib-data-ui 1.20% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LRNcardozoWDF
LRNcardozoWDF deleted the revert-7217-sdlc/sdk-update branch August 6, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant