Skip to content

Incorrect parameter ordering in element_sub #129

Open

Description

@isaac868

The parameter ordering of a call to element_wise within one of the element_sub overloads is incorrect.

Since the function signature of element_wise is:

void element_wise(ublas::matrix<T, L1, opencl::storage> const &a,
	ublas::matrix<T, L2, opencl::storage> const &b,
	ublas::matrix<T, L3, opencl::storage> &result,
	O op, compute::command_queue& queue)

The call in the first element_sub overload should be changed to:
element_wise(a, b, result, compute::minus<T>(), queue);
as opposed to
element_wise(a, b, compute::minus<T>(), result, queue);

Activity

  1. harjot20022001 commented on Dec 30, 2021

    @harjot20022001

    I have submitted a pr that had passed the checks. Can someone review it so it can be merged?

  2. Neel-Shah-29 commented on Jan 9, 2022

    @Neel-Shah-29
    Contributor

    Is there any ongoing effort to solve this issue? If not, I am interested in working on it. Please assign the task to me

  3. Neel-Shah-29 commented on Feb 13, 2022

    @Neel-Shah-29
    Contributor

    Is this issue resolved or yet remaining to be solved?

  4. isaac868 commented on Feb 13, 2022

    @isaac868
    Author

    It is not resolved yet. It appears there is are two prq's for this at #128 and #146 (review). However, they need two people with write access to approve them. The one wihtout all the merge conflicts should probably be the one merged into the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions