Repository navigation

Refactor coordinates - #2873

Closed

tomc271 wants to merge 519 commits into

nextfrom

refactor-coordinates

Closed

Refactor coordinates#2873
tomc271 wants to merge 519 commits into
nextfrom
refactor-coordinates

This pull request is big! We're only showing the most recent 250 commits

Commits on Mar 2, 2024
Commits on Mar 5, 2024
Commits on Mar 11, 2024
- Clang-tidy: "Use auto when initialising with a template cast to avoid duplicating the type name"
  tomchapman
  committed
  b371136
Commits on Mar 12, 2024
- Bug fix: Don't specify region when setting contravariant metric tensor in 'interpolateFieldsFromOtherCoordinates' method.
  tomchapman
  committed
  de146f1
- Merge remote-tracking branch 'remotes/boutproject/next' into refactor-coordinates
  tomchapman
  committed
  7ad4b39
Commits on Mar 13, 2024
- Update petsc cases to use new getters.
  tomchapman
  committed
  d1516db
- Remove calls to geometry().
  tomchapman
  committed
  518672d
- Set death_test_style to "threadsafe", to prevent timeout.
  tomchapman
  committed
  cf6df73
Commits on Mar 14, 2024
- Add [[maybe_unused]] attribute to 'J' parameter in Coordinates constructor.
  tomchapman
  committed
  3cddd46
- Revert expansion of COPY_STRIPE macro.
  tomchapman
  committed
  99751c6
- Remove redundant function 'ChristoffelSymbols::map' (instead just calling ChristoffelSymbols::applyToComponents() directly).
  tomchapman
  committed
  5d0a696
- Revert "Minor fixes."
  tomchapman
  committed
  15815f4
- Apply clang-format changes
  
  tomc271
  authored and
  github-actions[bot]
  committed
  b8a2158
- More updates to examples and tests to use dx setter.
  tomchapman
  committed
  c46d0ab
- Merge remote-tracking branch 'remotes/boutproject/refactor-coordinates' into refactor-coordinates
  tomchapman
  committed
  550a42d
- Rename file MetricTensor to use snake case.
  tomchapman
  committed
  9466334
- Updated another example (gravity_reduced) to use new metric tensor setters.
  tomchapman
  committed
  031fb4b
- Apply clang-format changes
  
  tomc271
  authored and
  github-actions[bot]
  committed
  d259faf
- Remove obsolete comment.
  tomchapman
  committed
  ad36b89
Commits on Mar 15, 2024
- Make jacobian setter take a const reference.
  tomchapman
  committed
  e7bdfcf
- Call communicateAndCheckMeshSpacing() in ChristoffelSymbols constructor (immediately before calling the differential operator functions).
  tomchapman
  committed
  2e46100
Commits on Mar 25, 2024
Commits on Mar 26, 2024
Commits on Mar 29, 2024
- Disable "Laplacian solver in 2D (X-Y)" for the BOUT_USE_METRIC_3D case.
  tomchapman
  committed
  c0b4e04
- Fix test-laplacexz: Use a non-zero value for off-diagonal components that gives a valid inverse metric (i.e. all diagonal components positive).
  tomchapman
  committed
  cee7596
- Apply clang-format changes
  
  tomc271
  authored and
  tomchapman
  committed
  6232eb4
Commits on Apr 8, 2024
- Merge remote-tracking branch 'remotes/boutproject/next' into refactor-coordinates
  tomchapman
  committed
  9498ae1
Commits on May 2, 2024
- Merge branch 'next' into refactor-coordinates
  tomchapman
  committed
  59faafd
Commits on May 10, 2024
- include <functional>
  
  Tom C
  authored and
  Tom C
  committed
  17f7097
Commits on May 14, 2024
Commits on May 15, 2024
- Do the copying in the method that calls Mesh::communicate(), so that the copies are still in scope when they are used.
  tomchapman
  committed
  736198b
- Merge branch 'communicate-const-qualified' into refactor-coordinates
  tomchapman
  committed
  b308f6c
Commits on May 16, 2024
Commits on May 22, 2024
- Coordinates::communicate() method needs to take a non-const parameter to be able to modify it.
  tomchapman
  committed
  545ede8
- Fix copy-paste errors introduced during refactoring.
  tomchapman
  committed
  e7df6bc
- Restore #include "impls/bout/boutmesh.hxx"
  tomchapman
  committed
  04c9399
- Merge branch 'communicate-fix' into fx01
  tomchapman
  committed
  c703dd3
- Revert "More [[maybe_unused]] attributes."
  tomchapman
  committed
  8194863
- Revert "Add [[maybe_unused]] attributes."
  tomchapman
  committed
  3ce726c
- Revert "Prefer const."
  tomchapman
  committed
  53622ec
- Add test CheckCovariantCalculatedFromContravariant to CoordinatesTest suite.
  tomchapman
  committed
  8650f4f
- Add test CheckContravariantCalculatedFromCovariant to CoordinatesTest suite.
  tomchapman
  committed
  d32f7a6
Commits on Jun 3, 2024
- Merge remote-tracking branch 'remotes/boutproject/next' into refactor-coordinates
  tomchapman
  committed
  fb181e9
Commits on Jun 4, 2024
Commits on Jun 6, 2024
- Apply clang-format changes
  
  tomc271
  authored and
  github-actions[bot]
  committed
  64ed06e
- Restore semicolons after macros.
  tomchapman
  committed
  5ff4df3
- Revert accidental renaming in docs.
  tomchapman
  committed
  187c081
- Revert "Clang-Tidy: Method can be made static."
  tomchapman
  committed
  e5d1c77
- Revert "More unused #include directives."
  tomchapman
  committed
  12e769c
- Clang-Tidy: Static member accessed through instance.
  tomchapman
  committed
  b692beb
- Clang-Tidy: variable can be declared 'const'.
  tomchapman
  committed
  804d77a
- Apply clang-format changes
  
  tomc271
  authored and
  tomchapman
  committed
  ae29dc8
Commits on Jun 7, 2024
- Rename setBoundaryCells() to readFromMesh(), and interpolateFieldsFromOtherCoordinates() to interpolateFromCoordinates().
  tomchapman
  committed
  77896a3
Commits on Jun 10, 2024
Commits on Sep 22, 2024
- Apply clang-format changes
  
  tomc271
  authored and
  tomchapman
  committed
  33111b3
- Add overload getters for dx, dy, and dz, that give the value at a particular x, y (or x, y, z) position.
  
  tomc
  authored and
  tomchapman
  committed
  2dfdb42
- Use overloaded getters for dx, dy, and dz.
  tomchapman
  committed
  4c2a1d1
- Merge remote-tracking branch 'remotes/boutproject/next' into refactor-coordinates
  tomchapman
  committed
  dc2b0c3
Commits on Sep 23, 2024
- Merge remote-tracking branch 'remotes/boutproject/next' into refactor-coordinates
  tomchapman
  committed
  a5157ce
Commits on Sep 25, 2024
Commits on Sep 27, 2024
- Use overloaded getters for metric tensor components.
  tomchapman
  committed
  4852b00
Commits on Oct 1, 2024
Commits on Oct 2, 2024
- Apply clang-format changes
  
  tomc271
  authored and
  github-actions[bot]
  committed
  3d8198f
Commits on Oct 23, 2024
- Revert "x, y, z are accessed through getters on BoundaryRegionPar."
  ZedThree
  committed
  cbce1b4
- Fix clang-tidy const-correctness warnings
  ZedThree
  committed
  fa6663d
- Merge branch 'next' into refactor-coordinates
  ZedThree
  committed
  c85f2ad
Commits on Oct 24, 2024
- Rename metric tensor component members
  ZedThree
  committed
  5b61d2b
- Use `std::array` instead of C array
  ZedThree
  committed
  e2d3c52
- Fix some clang-tidy warnings in metric_tensor
  ZedThree
  committed
  687f0c4
- Reduce duplication in metric tensor between 2D/3D metric a little
  ZedThree
  committed
  2411ab2
- Inline metric tensor function application `map`
  ZedThree
  committed
  1213035
- Use free-function derivatives in metric tensor classes
  ZedThree
  committed
  e5010e4
- Remove some unused ctors from metric tensor classes
  ZedThree
  committed
  a926df1
- Ensure metric derivatives are always communicated
  ZedThree
  committed
  ff3fdef
- Remove `MetricTensor::setLocation`
  ZedThree
  committed
  676f0a0
- Pull out duplicated region name
  ZedThree
  committed
  ff12e4a
- Remove specialised `setDy`, `setJ` overloads
  ZedThree
  committed
  8a1d040
- Ensure grid spacings, Bxy, J, are always communicated
  ZedThree
  committed
  0663ea8
- Ensure metric terms are always communicated
  ZedThree
  committed
  a4fe574
- Simplify `recalculateJacobian` a little
  ZedThree
  committed
  b276d74
- Eliminate some unnecessary local variables
  ZedThree
  committed
  61196bf
- Inline some single-use functions
  ZedThree
  committed
  42dc6ee
- Fix wrong type in MMS/gbs
  ZedThree
  committed
  47cff9e
Commits on Dec 20, 2024
- Set coordinates on FakeMesh
  tomchapman
  committed
  15cffda
Commits on Dec 22, 2024
- Add optional boolean parameter `communicate` to Coordinates setters and MetricTensor inverse() method
  tomchapman
  committed
  6c69d6a
Commits on Jan 8, 2025
- Add Coordinates::communicateDz() and call after constructing Coordinates
  tomchapman
  committed
  77fb0c9
- Fix bug in test_snb
  tomchapman
  committed
  09162ca
Commits on Jan 10, 2025
- Apply clang-format changes
  
  tomc271
  authored and
  github-actions[bot]
  committed
  834b090
Commits on Jan 17, 2025
- Merge pull request #3056 from boutproject/fix-after-reactoring-communicate
  bendudson
  authored
  e117fa5
Commits on Jan 28, 2025
- Merge remote-tracking branch 'remotes/boutproject/next' into refactor-coordinates-with-next-merged-in
  tomchapman
  committed
  4b5bee3
Commits on Feb 11, 2025
- Fix merge
  tomchapman
  committed
  52b817c
Commits on Feb 14, 2025
- Formatting (whitespace changes only)
  tomchapman
  committed
  fd099bf
Commits on Feb 21, 2025
- Fix for failing fci tests. Need to use Coordinates::DDY() not bout::derivatives::index::DDY()
  tomchapman
  committed
  d52a724
- Revert "Use free-function derivatives in metric tensor classes"
  tomchapman
  committed
  f7706f7
- Apply black changes
  
  tomc271
  authored and
  github-actions[bot]
  committed
  58b66f6
Commits on Apr 20, 2026
- Apply formatting
  ZedThree
  committed
  80e01ad
- Merge branch 'next' into refactor-coordinates
  ZedThree
  committed
  1b3b372
- Use single definition of `FieldMetric`
  ZedThree
  committed
  7fcac1b