Repository navigation

Cylindrical to Cartesian - #3139

Closed

tomc271 wants to merge 21 commits into

dry-up-examplesfrom

cylindrical-to-cartesian

Closed

Cylindrical to Cartesian#3139
tomc271 wants to merge 21 commits into
dry-up-examplesfrom
cylindrical-to-cartesian

Commits on Apr 28, 2025
- Add TokamakOptions::CylindricalCoordinatesToCartesian()
  tomchapman
  committed
  9fba061
- Add test fixture CoordinateTransformTest, and test CylindricalToCartesian
  tomchapman
  committed
  4c50b3d
- Fix CylindricalCoordinatesToCartesian()
  tomchapman
  committed
  a63f7d6
- Fix test CylindricalToCartesian
  tomchapman
  committed
  71f9429
- Calculate toroidal angle, as 2*pi/n
  tomchapman
  committed
  06df2d6
Commits on May 21, 2025
- Modify generation of test values for Rxy
  tomchapman
  committed
  49ae23b
- Use a realistic set of test points as input
  tomchapman
  committed
  5387b8a
- Use standard library functions for sin() and cos()
  tomchapman
  committed
  c1ed640
- Use a vector for the toroidal angle values. Iterate over all r, theta values
  tomchapman
  committed
  e6e1d62
- Prefer const
  tomchapman
  committed
  bd86979
- Use range-based loops
  tomchapman
  committed
  392ae19
- Pass parameters by reference
  tomchapman
  committed
  25c850e
- FakeMeshFixture has nx=3, ny=5, nz=7
  tomchapman
  committed
  bf20998
- Use nx and ny variables, to avoid magic numbers
  tomchapman
  committed
  7296f4b
- Bug fix: toroidal angle is not an int
  tomchapman
  committed
  19d6454
Commits on May 22, 2025
- Add explanatory comments to test
  tomchapman
  committed
  b9757cd
- Don't instantiate Field3D from Field2D
  tomchapman
  committed
  0fb5b3f
- Just test min and max values
  tomchapman
  committed
  02d4cbf
Commits on Jun 10, 2025
- Add nx, ny, nz as optional arguments to FakeMeshFixture constructor
  tomchapman
  committed
  086a8b1
- Use nz=8 in CoordinateTransformTest
  tomchapman
  committed
  0d43214
Commits on Jun 12, 2025
- Use type alias FakeMeshFixture = FakeMeshFixture_tmpl<3, 5, 7> as a shim to allow FakeMeshFixture to be used with default values for nx, ny, nz
  tomchapman
  committed
  64b8bd0

Commits

Commits on Apr 28, 2025

Commits on May 21, 2025

Commits on May 22, 2025

Commits on Jun 10, 2025

Commits on Jun 12, 2025