Repository navigation
Add Spanish locale and Euro PDF test coverage - #57
Closed
hugoarbones wants to merge 2 commits into
Closed
hugoarbones wants to merge 2 commits into
hugoarbones wants to merge 2 commits into
Conversation
Co-authored-by: hugoarbones <32848906+hugoarbones@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The new test mutates process-wide environment and creates a persistent temp file without cleanup, which can leak state/artifacts across the test suite.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds Spanish (es) localization support and validates Euro-formatted output in generated PDFs, improving multi-locale invoice generation confidence.
Changes:
- Added a Spanish/Euro-focused PDF generation test.
- Documented how to enable Spanish language and Euro formatting in the README.
- Introduced Spanish gettext translations (
messages.po) for invoice/PDF labels.
File summaries
| File | Description |
|---|---|
| tests/test_pdf.py | Adds a new test asserting Spanish labels and EUR formatting appear in the generated PDF text. |
| README.rst | Documents environment and invoice settings for Spanish + Euro formatting. |
| InvoiceGenerator/locale/es/LC_MESSAGES/messages.po | Adds Spanish translations for invoice/PDF UI strings. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
hugoarbones
marked this pull request as draft
September 1, 2026 10:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.