Skip to content

Pr 77 link check improvements - #78

Open
domguinard wants to merge 5 commits into
mainfrom
pr-77-link-check-improvements
Open

domguinard wants to merge 5 commits into
mainfrom
pr-77-link-check-improvements

Conversation

@domguinard

Copy link
Copy Markdown
Collaborator

Improving on #77 (but I could not push to this branch as it is coming from a fork).

@ilkedemir

Copy link
Copy Markdown

I did not add the SBR API check as I was not sure if we should handle a response like Cannot GET /api/v1 and {"error":"Subsystem token required","code":"SUBSYSTEM_TOKEN_MISSING"} as it is not clear whether the API is really nonexistent or the request is invalid, or whether we should treat them the same.

Also it seems you removed the issue creation, which is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants