Refactor - #12
Merged
Merged
Refactor#12
Conversation
• Replaced ViewModelBase with ObservableObject • Replaced Set(...) with SetProperty(...) • Replaced Messenger.Default usage with WeakReferenceMessenger • Removed MvvmLight SimpleIoc/ServiceLocator usage from ViewModelLocator • Added a small CommunityToolkit message type for the About view trigger • Cleaned obsolete MvvmLight using directives
(but still fail to build in legacy project style)
- Potential GDI/memory leak in icon handling - Nullable filter parameters are not handled safely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modernizes the window management and interop layers of the application by migrating from the deprecated
PInvokeand customNativeMethodsto the official Windows.Win32 (CsWin32) interop library. It also improves resource management, updates the build pipeline to use the .NET SDK withdotnetCLI, and removes legacy dependencies. The most important changes are grouped below:Migration to Windows.Win32 (CsWin32) Interop
PInvokeand customNativeMethodswith the officialWindows.Win32interop APIs inWindowInstanceInfo,WindowInstanceUtil, and related files, updating types (e.g.,IntPtrtoHWND) and method calls accordingly. (Stealth/Core/WindowInstanceInfo.cs,Stealth/Core/WindowInstanceUtil.cs, [1] [2] [3] [4] [5] [6] [7] [8]Stealth/Core/NativeMethods.csfile.Resource Management Improvements
IDisposableinWindowInstanceInfoto prevent resource leaks. (Stealth/Core/WindowInstanceInfo.cs, [1] [2]Build Pipeline Modernization
dotnet restore,dotnet build,dotnet test) instead of MSBuild/NuGet, set the solution file path, and replaced deprecated actions with their latest versions. (.github/workflows/msbuild.yml, [1] [2]Dependency and Code Cleanup
GalaSoft.MvvmLightand related dispatcher initialization code fromApp.xaml.csandMainService.cs. (Stealth/App.xaml.cs, [1] [2];Stealth/Model/MainService.cs, [3]System.Runtime.CompilerServices.Unsafebinding redirect fromApp.configas it is no longer needed. (Stealth/App.config, Stealth/App.configL16-L19)Data Model and Event Handling Improvements
Stealth/Model/MainService.cs, [1] [2]