Repository navigation
test: validate TEE batcher upgrades in Nitro CI - #545
Conversation
4a7ea28 to
5abe12c
Compare
ab158af to
343623c
Compare
jjeangal
changed the title
343623c to
375390c
Compare
b59d0dc to
f1133aa
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1133aa696
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ce66d8c to
572a19b
Compare
f1133aa to
714f42b
Compare
A connection accepted before the vsock bridge is up could block conn.Read indefinitely, bypassing waitForEnclaveReady's two-minute timeout. Dial with the context and cap each read at 5s (or the context deadline) so stalled connections are retried. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3df51fc8d8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| _ = conn.SetReadDeadline(deadline) | ||
| buf := make([]byte, 16) | ||
| n, _ := conn.Read(buf) |
There was a problem hiding this comment.
If the vsock/TCP bridge returns the six-byte READY\n payload across multiple reads, this single Read can receive only a prefix and then immediately close the connection. Because the entrypoint's nc -l serves the readiness marker only once, subsequent polls cannot recover and the test times out despite the enclave being ready; keep reading until the marker, EOF, or the configured deadline.
Useful? React with 👍 / 👎.
Run a baseline batcher in an AWS Nitro enclave, verify that its batches reach L1, then stop it and submit an L2 transaction. Start the candidate batcher and verify that it recovers the pending transaction and continues publishing.
The manual workflow builds both batcher images and runs the test on an ephemeral EC2 enclave runner. It uses GitHub App authentication and a dedicated GitHub OIDC role scoped to
upgrade-test-ci, configures the Nitro allocator, and removes the runner after the test. The test waits for a local Espresso header with an L1 finality reference before starting either batcher.Validation: full Nitro upgrade CI passed on
3352db346c. The complete workflow must be rerun after the branch base is refreshed.Asana: https://app.asana.com/0/0/1219024255605158