Skip to content

[productions] Clean up the settings pages - #2283

Merged
frankrousseau merged 1 commit into
cgwire:mainfrom
frankrousseau:cleanup/production-settings
Oct 20, 2026
Merged

frankrousseau merged 1 commit into
cgwire:mainfrom
frankrousseau:cleanup/production-settings

Conversation

@frankrousseau

Copy link
Copy Markdown
Contributor

Problem

  • The production and project template settings pages and their pages/production/ subcomponents drifted from the script conventions: unordered imports, no sections, interleaved watchers.
  • Dead code remained: an unlistened confirm emit and commented-out fields in ProductionParameters, schedule date watchers in ProductionTaskType left over from the moved date fields, unused refs and CSS rules.
  • ProjectTemplateSettings repeated the "dispatch then reload" and "import links" sequences across 15 handlers, and mutated descriptors inside a computed.

Solution

  • Sort imports in three blocks and group the scripts by section in every file of the perimeter.
  • Remove the dead emits, refs, watchers, commented-out template and CSS rules without a target.
  • Share one updateTemplate and one importLinks helper in ProjectTemplateSettings, build the descriptor list without mutation, and simplify the small helpers (optional chaining, Object.fromEntries, merged watchers).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@frankrousseau
frankrousseau merged commit a1824ca into cgwire:main Oct 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant