Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changelog/20260721132553_ck_10480.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
type: Major breaking change
scope:
- ckeditor5-dev-translations
see:
- https://github.com/ckeditor/ckeditor5-commercial/issues/10480
---

Translation files generated for Simplified and Traditional Chinese are no longer ambiguous.

* `zh_CN` (Simplified Chinese) now generates the `zh-hans.po` file instead of `zh-cn.po`.
* `zh_TW` (Traditional Chinese) now generates the `zh-hant.po` file instead of `zh.po`.
9 changes: 9 additions & 0 deletions .changelog/20260728081737_ck_10480.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
type: Major breaking change
scope:
- ckeditor5-dev-translations
see:
- https://github.com/ckeditor/ckeditor5-commercial/issues/10480
---

The `nb` locale (Norwegian Bokmål) is no longer supported. Its translations were incomplete, and Bokmål is already covered by the default `no` (Norwegian) locale.
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ const SUPPORTED_LOCALES = [
'ms', // Malay
'ne_NP', // Nepali (Nepal)
'no', // Norwegian
'nb', // Norwegian Bokmål
Comment thread
Mati365 marked this conversation as resolved.
Resolved
Comment thread
Mati365 marked this conversation as resolved.
Resolved
'oc', // Occitan (post 1500)
'fa', // Persian
'pl', // Polish
Expand All @@ -78,12 +77,12 @@ const SUPPORTED_LOCALES = [
'uz', // Uzbek
'vi' // Vietnamese
];

const LOCALES_FILENAME_MAP = {
'ne_NP': 'ne',
'si_LK': 'si',
'sr@latin': 'sr-latn',
'zh_TW': 'zh'
'zh_CN': 'zh-hans',
'zh_TW': 'zh-hant'
};

/**
Expand Down
19 changes: 15 additions & 4 deletions packages/ckeditor5-dev-translations/tests/utils/getlanguages.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,25 @@ describe( 'getLanguages()', () => {
} );
} );

it( 'should use predefined filename if defined', () => {
it( 'should return Chinese (Simplified) language', () => {
const languages = getLanguages();
const languageChineseTaiwan = languages.find( l => l.localeCode === 'zh_TW' );
const languageChineseSimplified = languages.find( l => l.localeCode === 'zh_CN' );

expect( languageChineseTaiwan ).toEqual( {
expect( languageChineseSimplified ).toEqual( {
localeCode: 'zh_CN',
languageCode: 'zh',
languageFileName: 'zh-hans'
Comment thread
cursor[bot] marked this conversation as resolved.
Resolved
} );
} );

it( 'should return Chinese (Traditional) language', () => {
const languages = getLanguages();
const languageChineseTraditional = languages.find( l => l.localeCode === 'zh_TW' );

expect( languageChineseTraditional ).toEqual( {
localeCode: 'zh_TW',
languageCode: 'zh',
languageFileName: 'zh'
languageFileName: 'zh-hant'
} );
} );
} );