Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c628d2b
Remove the depcheck-based dependency checker in favor of Knip.
filipsobol Jul 21, 2026
c19525b
Exit with an error code when syncpack fails to start.
filipsobol Jul 21, 2026
82a30b3
Move type packages used by production code to production dependencies.
filipsobol Jul 21, 2026
93aa074
Reduce the dependency check configuration boilerplate.
filipsobol Jul 21, 2026
0c96ca1
Use ESM for the syncpack configuration.
filipsobol Jul 21, 2026
a7ec603
Deduplicate the entry and project patterns in the dependency check co…
filipsobol Jul 21, 2026
b17a442
Restore the CSS import and self-import checks and launch syncpack por…
filipsobol Jul 21, 2026
d534821
Remove the CSS import check, as the repository has no CSS import surf…
filipsobol Jul 21, 2026
396253f
Add regression tests for the dependency checks.
filipsobol Jul 21, 2026
2de4de1
Merge remote-tracking branch 'origin/master' into ci/4564-replace-dep…
filipsobol Jul 23, 2026
04acb56
Remove unused variable.
filipsobol Jul 23, 2026
39d3dc9
Run Knip through pnpm and ESLint through its Node API in the regressi…
filipsobol Jul 24, 2026
f55944c
Move the Knip configuration to scripts/knip/dependencies.ts, matching…
filipsobol Jul 24, 2026
4dd9d5b
Test pre-release version of Knip with improved types detection.
filipsobol Jul 28, 2026
11cd75e
Merge remote-tracking branch 'origin/master' into ci/4564-replace-dep…
filipsobol Aug 18, 2026
8a91c6e
Finalize the Knip and syncpack migration.
filipsobol Aug 18, 2026
3e16874
Use Knip workspace defaults.
filipsobol Aug 18, 2026
d8116f6
Restore strict Knip production checks.
filipsobol Aug 19, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
type: Major breaking change
scope:
---

Removed the `@ckeditor/ckeditor5-dev-dependency-checker` package. It was built on top of the deprecated `depcheck` library. Use [`knip`](https://knip.dev/) to validate dependencies instead.
3 changes: 3 additions & 0 deletions .circleci/template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ jobs:
- run:
name: Validate versions of dependencies
command: pnpm run check-versions-match
- run:
name: Validate dependencies
command: pnpm run check-dependencies
Comment thread
cursor[bot] marked this conversation as resolved.
Resolved
- run:
name: Validate naming and location of test files
command: pnpm run check-test-conventions
Expand Down
35 changes: 35 additions & 0 deletions .syncpackrc.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
/**
* @license Copyright (c) 2003-2026, CKSource Holding sp. z o.o. All rights reserved.
* For licensing, see LICENSE.md.
*/

/**
* Configuration for `syncpack`, which ensures that `dependencies` and `devDependencies`
* across the repository use consistent versions. Executed in CI via the
* `check-versions-match` script. Run it with the `--fix` argument to resolve reported
* issues automatically.
*
* Unlike in the `ckeditor5` repository, version ranges (the `^` operator) are allowed here.
* When the same dependency is declared with different versions, the highest one wins.
*/
export default {
source: [
'package.json',
'packages/*/package.json'
],

versionGroups: [
{
label: 'Packages developed in this repository must use the workspace protocol.',
dependencies: [ '$LOCAL' ],
pinVersion: 'workspace:*'
}
],

semverGroups: [
{
dependencies: [ '$LOCAL' ],
isIgnored: true
}
]
};
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ This repository is a monorepo. It contains multiple npm packages.
| [`@ckeditor/ckeditor5-dev-bump-year`](/packages/ckeditor5-dev-bump-year) | [![npm version](https://badge.fury.io/js/%40ckeditor%2Fckeditor5-dev-bump-year.svg)](https://www.npmjs.com/package/@ckeditor/ckeditor5-dev-bump-year) |
| [`@ckeditor/ckeditor5-dev-changelog`](/packages/ckeditor5-dev-changelog) | [![npm version](https://badge.fury.io/js/%40ckeditor%2Fckeditor5-dev-changelog.svg)](https://www.npmjs.com/package/@ckeditor/ckeditor5-dev-changelog) |
| [`@ckeditor/ckeditor5-dev-ci`](/packages/ckeditor5-dev-ci) | [![npm version](https://badge.fury.io/js/%40ckeditor%2Fckeditor5-dev-ci.svg)](https://www.npmjs.com/package/@ckeditor/ckeditor5-dev-ci) |
| [`@ckeditor/ckeditor5-dev-dependency-checker`](/packages/ckeditor5-dev-dependency-checker) | [![npm version](https://badge.fury.io/js/%40ckeditor%2Fckeditor5-dev-dependency-checker.svg)](https://www.npmjs.com/package/@ckeditor/ckeditor5-dev-dependency-checker) |
| [`@ckeditor/ckeditor5-dev-docs`](/packages/ckeditor5-dev-docs) | [![npm version](https://badge.fury.io/js/%40ckeditor%2Fckeditor5-dev-docs.svg)](https://www.npmjs.com/package/@ckeditor/ckeditor5-dev-docs) |
| [`@ckeditor/ckeditor5-dev-license-checker`](/packages/ckeditor5-dev-license-checker) | [![npm version](https://badge.fury.io/js/%40ckeditor%2Fckeditor5-dev-license-checker.svg)](https://www.npmjs.com/package/@ckeditor/ckeditor5-dev-license-checker) |
| [`@ckeditor/ckeditor5-dev-manual-server`](/packages/ckeditor5-dev-manual-server) | [![npm version](https://badge.fury.io/js/%40ckeditor%2Fckeditor5-dev-manual-server.svg)](https://www.npmjs.com/package/@ckeditor/ckeditor5-dev-manual-server) |
Expand Down
3 changes: 2 additions & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ export default defineConfig( [
{
extensions: [ '.ts', '.js', '.json' ]
}
]
],
'ckeditor5-rules/no-scoped-imports-within-package': 'error'
}
},
{
Expand Down
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
},
"type": "module",
"devDependencies": {
"@ckeditor/ckeditor5-dev-changelog": "workspace:*",
"@inquirer/prompts": "^7.10.1",
"@listr2/prompt-adapter-inquirer": "^2.0.22",
"@vitest/coverage-v8": "^4.1.2",
Expand All @@ -28,10 +29,11 @@
"globals": "^16.5.0",
"husky": "^9.1.7",
"js-yaml": "^4.2.0",
"knip": "^6.32.2",
"lint-staged": "^16.4.0",
"listr2": "^8.3.3",
"minimist": "^1.2.8",
"semver": "^7.7.4",
"syncpack": "^15.3.2",
"typescript": "5.5.4",
"upath": "^2.0.1",
"vite": "^8.2.1",
Expand All @@ -52,7 +54,7 @@
"typecheck": "tsc",
"precommit": "lint-staged",
"reinstall": "pnpx rimraf --glob \"**/node_modules\" && pnpm install",
"check-dependencies": "ckeditor5-dev-dependency-checker"
"check-dependencies": "knip --config ./scripts/knip/dependencies.ts --dependencies --no-config-hints && knip --config ./scripts/knip/dependencies.ts --dependencies --production --strict --no-config-hints"
},
"lint-staged": {
"**/*": [
Expand Down
7 changes: 2 additions & 5 deletions packages/ckeditor5-dev-build-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
},
"devDependencies": {
"@types/node": "^22.19.17",
"@vitest/coverage-v8": "^4.1.2",
"type-fest": "^4.41.0",
"@vitest/coverage-v8": "^4.1.2",
"vitest": "^4.1.2"
},
"scripts": {
Expand All @@ -47,8 +47,5 @@
"test": "vitest run --config vitest.config.ts",
"coverage": "vitest run --config vitest.config.ts --coverage",
"test:dev": "vitest dev"
},
"depcheckIgnore": [
"@vitest/coverage-v8"
]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@

'use strict';

import { generateTemplate } from '@ckeditor/ckeditor5-dev-changelog/dist/template.js';
import { generateTemplate } from '../dist/template.js';

await generateTemplate();
8 changes: 2 additions & 6 deletions packages/ckeditor5-dev-changelog/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"dependencies": {
"@11ty/gray-matter": "^2.1.0",
"@ckeditor/ckeditor5-dev-utils": "workspace:*",
"@types/semver": "^7.7.1",
"cac": "^7.0.0",
"date-fns": "^4.1.0",
"glob": "^13.0.6",
Expand All @@ -38,7 +39,6 @@
"upath": "^2.0.1"
},
"devDependencies": {
"@types/semver": "^7.7.1",
"@vitest/coverage-v8": "^4.1.2",
"rolldown": "^1.1.2",
"vitest": "^4.1.2"
Expand All @@ -49,9 +49,5 @@
"test": "vitest run --config vitest.config.ts",
"coverage": "vitest run --config vitest.config.ts --coverage",
"test:dev": "vitest dev"
},
"depcheckIgnore": [
"@vitest/coverage-v8",
"typescript"
]
}
}
6 changes: 0 additions & 6 deletions packages/ckeditor5-dev-dependency-checker/CHANGELOG.md

This file was deleted.

16 changes: 0 additions & 16 deletions packages/ckeditor5-dev-dependency-checker/LICENSE.md

This file was deleted.

17 changes: 0 additions & 17 deletions packages/ckeditor5-dev-dependency-checker/README.md

This file was deleted.

This file was deleted.

Loading