Repository navigation
Remove the custom dependency checker in favor of Knip and syncpack #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c628d2b
Remove the depcheck-based dependency checker in favor of Knip.
filipsobol c19525b
Exit with an error code when syncpack fails to start.
filipsobol 82a30b3
Move type packages used by production code to production dependencies.
filipsobol 93aa074
Reduce the dependency check configuration boilerplate.
filipsobol 0c96ca1
Use ESM for the syncpack configuration.
filipsobol a7ec603
Deduplicate the entry and project patterns in the dependency check co…
filipsobol b17a442
Restore the CSS import and self-import checks and launch syncpack por…
filipsobol d534821
Remove the CSS import check, as the repository has no CSS import surf…
filipsobol 396253f
Add regression tests for the dependency checks.
filipsobol 2de4de1
Merge remote-tracking branch 'origin/master' into ci/4564-replace-dep…
filipsobol 04acb56
Remove unused variable.
filipsobol 39d3dc9
Run Knip through pnpm and ESLint through its Node API in the regressi…
filipsobol f55944c
Move the Knip configuration to scripts/knip/dependencies.ts, matching…
filipsobol 4dd9d5b
Test pre-release version of Knip with improved types detection.
filipsobol 11cd75e
Merge remote-tracking branch 'origin/master' into ci/4564-replace-dep…
filipsobol 8a91c6e
Finalize the Knip and syncpack migration.
filipsobol 3e16874
Use Knip workspace defaults.
filipsobol d8116f6
Restore strict Knip production checks.
filipsobol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
.changelog/20260721140527_ci_4564_remove_dependency_checker.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| type: Major breaking change | ||
| scope: | ||
| --- | ||
|
|
||
| Removed the `@ckeditor/ckeditor5-dev-dependency-checker` package. It was built on top of the deprecated `depcheck` library. Use [`knip`](https://knip.dev/) to validate dependencies instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /** | ||
| * @license Copyright (c) 2003-2026, CKSource Holding sp. z o.o. All rights reserved. | ||
| * For licensing, see LICENSE.md. | ||
| */ | ||
|
|
||
| /** | ||
| * Configuration for `syncpack`, which ensures that `dependencies` and `devDependencies` | ||
| * across the repository use consistent versions. Executed in CI via the | ||
| * `check-versions-match` script. Run it with the `--fix` argument to resolve reported | ||
| * issues automatically. | ||
| * | ||
| * Unlike in the `ckeditor5` repository, version ranges (the `^` operator) are allowed here. | ||
| * When the same dependency is declared with different versions, the highest one wins. | ||
| */ | ||
| export default { | ||
| source: [ | ||
| 'package.json', | ||
| 'packages/*/package.json' | ||
| ], | ||
|
|
||
| versionGroups: [ | ||
| { | ||
| label: 'Packages developed in this repository must use the workspace protocol.', | ||
| dependencies: [ '$LOCAL' ], | ||
| pinVersion: 'workspace:*' | ||
| } | ||
| ], | ||
|
|
||
| semverGroups: [ | ||
| { | ||
| dependencies: [ '$LOCAL' ], | ||
| isIgnored: true | ||
| } | ||
| ] | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
87 changes: 0 additions & 87 deletions
87
packages/ckeditor5-dev-dependency-checker/bin/dependencychecker.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.