Skip to content

fix(mosaic): load member roles only for managers and show table notices as banners - #10166

Merged
alexcarpenter merged 3 commits into
austin/members-tab-wire-upfrom
carp/members-roles-managers-only
Oct 9, 2026
Merged

alexcarpenter merged 3 commits into
austin/members-tab-wire-upfrom
carp/members-roles-managers-only

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

Stacked on #10157.

  • Only viewers who can manage members now load organization roles. The model provides loadRoles only when canManage is true, and the roles machine starts in an unavailable state when no loader is passed. Before this, read-only viewers fetched /roles even though they never see the role select.
  • The members table notices now use Banner. The role-set migration notice is a warning banner with role='status'. The load, roles and role-change errors are negative banners with role='alert', and their retry buttons sit inside the banner.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 9, 2026 2:17pm UTC
swingset Ready Ready Preview Oct 9, 2026 2:17pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d5bdf12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: bcb3b628-b9d1-4b6a-860c-2ca9904a9e2e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@alexcarpenter
alexcarpenter merged commit 49466b0 into austin/members-tab-wire-up Oct 9, 2026
8 of 10 checks passed
@alexcarpenter
alexcarpenter deleted the carp/members-roles-managers-only branch October 9, 2026 14:16

This branch was successfully deployed

2 active deployments
Preview – swingset — d5bdf121 Deployed Oct 9, 2026 by vercel[bot]
Preview – clerk-js-sandbox — d5bdf121 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant