Repository navigation
fix(swingset): keep the page title above the pages in the profile transitions story - #10180
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 532ea31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The transition story now places the title above the panels, and the empty changeset follows the repository-supported workflow. No actionable merge-blocking risk remains. Pre-merge checks |
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Description
The "Page transitions" story on the Profile component page shows the page title below the page content.
The story makes
.cl-profile-content-bodya grid and pins every.cl-profile-content-paneltogrid-area: 1 / 1so the pages cross-fade in one cell. Since #10041, Profile renders the page title itself as the first child of that same content body. The title has no grid placement, so it auto-places into the next free cell: row 2, under the pages.This pins the pages to row 2 instead, so the title takes row 1 and the pages still share one cell for the cross-fade.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change