Skip to content

fix(swingset): keep the page title above the pages in the profile transitions story - #10180

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/profile-transitions-title
Oct 9, 2026
Merged

alexcarpenter merged 2 commits into
mainfrom
carp/profile-transitions-title

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

The "Page transitions" story on the Profile component page shows the page title below the page content.

The story makes .cl-profile-content-body a grid and pins every .cl-profile-content-panel to grid-area: 1 / 1 so the pages cross-fade in one cell. Since #10041, Profile renders the page title itself as the first child of that same content body. The title has no grid placement, so it auto-places into the next free cell: row 2, under the pages.

This pins the pages to row 2 instead, so the title takes row 1 and the pages still share one cell for the cross-fade.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 9, 2026 8:29pm UTC
swingset Ready Ready Preview Oct 9, 2026 8:29pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 532ea31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 285b59ea-1023-4730-8223-f992e46c0a73

📥 Commits

Reviewing files that changed from the base of the PR and between e830cfc and 532ea31.


You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: dea51ccd-9caa-4767-b459-9ce01e25af47

📥 Commits

Reviewing files that changed from the base of the PR and between 785190c and e830cfc.


📒 Files selected for processing (2)
  • .changeset/swingset-profile-transitions-title.md
  • packages/swingset/src/stories/profile.component.stories.tsx

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:


Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

The Transitions story now places the profile content panels at grid row 2 and column 1. A changeset file also gains empty YAML front matter.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: maxyinger


Merge Risk: ⚪ Minimal · up to e830c

The transition story now places the title above the panels, and the empty changeset follows the repository-supported workflow. No actionable merge-blocking risk remains.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check Passed The description clearly explains the Profile transitions story bug and the grid placement change that fixes it.
Title check Passed The title is concise, specific, and accurately identifies the fix that keeps the page title above the pages in the Profile transitions story.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10180

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10180

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10180

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10180

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10180

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10180

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10180

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10180

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10180

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10180

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10180

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10180

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10180

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10180

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10180

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10180

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10180

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10180

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10180

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10180

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10180

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10180

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10180

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10180

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10180

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10180

commit: 532ea31

@alexcarpenter
alexcarpenter enabled auto-merge (squash) October 9, 2026 20:27
@alexcarpenter
alexcarpenter merged commit 23b1e0d into main Oct 9, 2026
51 checks passed
@alexcarpenter
alexcarpenter deleted the carp/profile-transitions-title branch October 9, 2026 20:38

This branch was successfully deployed

2 active deployments
Preview – swingset — 532ea314 Deployed Oct 9, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 532ea314 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants