Skip to content

fix(mosaic): keep Flow transitioning for the root height transition only - #10181

Open
alexcarpenter wants to merge 2 commits into
flow-anim-refniementsfrom
flow-height-transitioning
Open

alexcarpenter wants to merge 2 commits into
flow-anim-refniementsfrom
flow-height-transitioning

Conversation

@alexcarpenter

@alexcarpenter alexcarpenter commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Description

Stacked on #10152.

Flow.Root's data-transitioning now lasts from a step change until the root's own height transition finishes. Before, it was built from the exiting steps plus a settle wait. Step enter/exit durations and the height duration are now independent: either can be longer without the height snapping at the end.

  • Flow.Step no longer reports exits to the root, so the exiting-step tracking and the settle state are removed.
  • useAnimationsFinished takes an optional filter. Flow waits only on height transitions, so other animations on the root (including infinite ones) can no longer leave it stuck in data-transitioning. Other callers don't pass a filter and are unchanged.
  • If the height does not transition (equal heights, reduced motion), the attribute clears at once.
  • The Flow README now describes data-transitioning and data-height-change.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bcf274f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 9, 2026 8:29pm UTC
swingset Ready Ready Preview Oct 9, 2026 8:29pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: e0dd5bda-6872-409e-a8e9-c25935051c3e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch was successfully deployed

2 active deployments
Preview – swingset — bcf274f9 Deployed Oct 9, 2026 by vercel[bot]
Preview – clerk-js-sandbox — bcf274f9 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant