Repository navigation
fix(mosaic): keep Flow transitioning for the root height transition only - #10181
alexcarpenter wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: bcf274f The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Description
Stacked on #10152.
Flow.Root'sdata-transitioningnow lasts from a step change until the root's ownheighttransition finishes. Before, it was built from the exiting steps plus a settle wait. Step enter/exit durations and the height duration are now independent: either can be longer without the height snapping at the end.Flow.Stepno longer reports exits to the root, so the exiting-step tracking and the settle state are removed.useAnimationsFinishedtakes an optionalfilter. Flow waits only onheighttransitions, so other animations on the root (including infinite ones) can no longer leave it stuck indata-transitioning. Other callers don't pass a filter and are unchanged.data-transitioninganddata-height-change.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change