Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha/10 #1372 +/- ##
===========================================
Coverage ? 81.92%
===========================================
Files ? 216
Lines ? 36843
Branches ? 0
===========================================
Hits ? 30184
Misses ? 4492
Partials ? 2167 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
https://github.com/cloudwego/cloudwego.github.io(Optional) Translate the PR title into Chinese.
修复 ADK 子智能体工具描述和工具名称自定义不生效的问题。
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
This PR fixes two customization regressions in the subagent middleware and Deep Agent integration.
First,
ToolDescriptionGeneratorand Deep Agent'sTaskToolDescriptionGeneratorare documented to return a complete tool description. Their returned text was previously passed throughpyfmtagain, causing valid descriptions containing JSON, code snippets, or ordinary braces to fail during agent construction.The generated description is now used verbatim. Framework-controlled placeholders are rendered only for the built-in description.
Second, setting
ToolNamechanged the registered tool name but left the built-in system prompt, tool description, background instructions, and agent-type reminder hardcoded toagent. For example, Deep Agent registered atasktool while instructing the model to callagent.The built-in model-facing text now consistently uses the effective tool name across:
schema.Messageandschema.AgenticMessage.Caller-provided descriptions, system prompts, and reminders remain unchanged and are not interpreted as templates.
zh(optional):
(Optional) Which issue(s) this PR fixes:
N/A. Fixes internal review findings M22-002 and M22-003.
(optional) The PR that updates user documentation:
N/A. This PR restores the documented customization behavior without introducing a usage-level API change.