Skip to content

python-math #23: feat(delphi): replay loader resolves private datasets under real_data/.local - #2651

Closed
jucor wants to merge 1 commit into
spr/edge/d5f1f51dfrom
spr/edge/a543ecf1
Closed

jucor wants to merge 1 commit into
spr/edge/d5f1f51dfrom
spr/edge/a543ecf1

Conversation

@jucor

@jucor jucor commented Jul 22, 2026 •

Copy link
Copy Markdown
Collaborator

dataset_dir() only globbed real_data/*-<slug>, so the five private datasets (bg2018, pakistan, engage, bg2050, FLI — slugs allowed in code per the 2026-07-05 naming policy; report-id directory names still never appear) were invisible to the replay harness and could not join the certify battery (the dataset × vote-schedule list that scripts/certify.py replays through both engines).

It now also searches real_data/.local/*-<slug>, with top-level (public) matches taking priority on a slug collision. Groundwork for extending the battery to all real_data datasets (GOAL_R1_PARITY.md, Battery section).

commit-id:a543ecf1


Stack:


⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Jul 22, 2026
@jucor jucor changed the title feat(delphi): replay loader resolves private datasets under real_data/.local feat(delphi): replay loader resolves private datasets under real_data… Jul 22, 2026
@jucor
jucor changed the base branch from spr/edge/d5f1f51d to edge July 22, 2026 06:16
@jucor
jucor force-pushed the spr/edge/a543ecf1 branch from 8d3c893 to 474f3b5 Compare July 22, 2026 06:16
@jucor jucor changed the title feat(delphi): replay loader resolves private datasets under real_data… feat(delphi): replay loader resolves private datasets under real_data/.local Jul 22, 2026
@jucor
jucor changed the base branch from edge to spr/edge/d5f1f51d July 22, 2026 06:16
This was referenced Jul 27, 2026
@jucor
jucor force-pushed the spr/edge/d5f1f51d branch from 5bf8560 to b0ec0c4 Compare July 28, 2026 00:11
@jucor
jucor force-pushed the spr/edge/a543ecf1 branch from 1f8024a to 75df9d6 Compare July 28, 2026 00:11
@jucor jucor changed the title feat(delphi): replay loader resolves private datasets under real_data/.local python-math #23: feat(delphi): replay loader resolves private datasets under real_data/.local Jul 28, 2026
…s under real_data/.local

`dataset_dir()` only globbed `real_data/*-<slug>`, so the five private datasets (bg2018, pakistan, engage, bg2050, FLI — slugs allowed in code per the 2026-07-05 naming policy; report-id directory names still never appear) were invisible to the replay harness and could not join the certify battery (the dataset × vote-schedule list that `scripts/certify.py` replays through both engines).

It now also searches `real_data/.local/*-<slug>`, with top-level (public) matches taking priority on a slug collision. Groundwork for extending the battery to all `real_data` datasets (`GOAL_R1_PARITY.md`, Battery section).

commit-id:a543ecf1
@jucor
jucor force-pushed the spr/edge/d5f1f51d branch from b0ec0c4 to fb8cc7a Compare July 28, 2026 01:10
@jucor
jucor force-pushed the spr/edge/a543ecf1 branch from 75df9d6 to f6346f7 Compare July 28, 2026 01:10
@jucor

jucor commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

Closing: this change is already on edge. Its commit f6346f7ca is byte-identical (same git patch-id) to 6b0a7c22b on edge, which landed with the production deploy #2685 (merged 2026-09-08).

This PR was one layer of a jj spr stack. The stack's commits reached edge through #2685, so this PR was never merged or closed automatically. Closing it loses nothing.

@jucor jucor closed this Oct 15, 2026
@jucor
jucor deleted the spr/edge/a543ecf1 branch October 15, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants