[JOSS Review] Minor typos / wording suggestions #802

Activity

1. tmigot

   assigned

   ocots

   on Jun 28, 2026
2. jbcaillau commented on Jul 27, 2026

   

   jbcaillau

   on Jul 27, 2026

   Member

   More actions

   Thank you @tmigot for this careful reading. All 12 suggestions have been accepted and applied as proposed in #813 (draft PR into the joss branch). Point-by-point below; note that your line numbers refer to the rendered PDF, so we also give the corresponding joss/paper.md source line.

   ---

   1. Line 52 (paper.md L57) — ✅ applied

   In contrast with InfiniteOpt.jl that is designed... → In contrast to InfiniteOpt.jl, which is designed...

   Now reads: "In contrast to InfiniteOpt.jl, which is designed as an extension of JuMP.jl, our package provides a modeler-agnostic approach…"

   2. Line 54 (paper.md L57) — ✅ applied

   Besides, contributing to... → Moreover, contributing to...

   3. Line 57 (paper.md L57) — ✅ applied

   ...Pontryagin's Maximum Principle and that heavily rely... → ...Pontryagin's Maximum Principle, which heavily rely...

   Now reads: "…these tools lack native support for shooting methods based on Pontryagin's Maximum Principle, which heavily rely on differential geometric primitives."

   4. Line 74 (paper.md L67) — ✅ applied

   Direct method tools → Direct-method tools

   5. Line 75 (paper.md L67) — ✅ applied

   Strong direct method implementations: → Strong direct-method implementations:

   6. Line 87 (paper.md L69) — ✅ applied

   PDE's → PDEs

   7. Line 121 (paper.md L85) — ✅ applied

   arbitrary user defined functions → arbitrary user-defined functions

   8. Line 146 (paper.md L89) — ✅ applied

   Non-regression on complex problems is increasingly driven by... → Regression testing on complex optimal control instances is increasingly supported by...

   Adopted verbatim; the existing hyperlink on OptimalControlProblems.jl is preserved. Your phrasing is clearer than ours — "non-regression" was a Gallicism on our part.

   9. Line 162 (paper.md L97) — ✅ applied

   Both approaches resort to iterative solvers... → Both approaches rely on iterative solvers...

   10. Line 163 (paper.md L97) — ✅ applied

   may converge or not, e.g. depending on the initial guess. → may or may not converge, e.g., depending on the initial guess.

   Applied including the comma after e.g.; the source keeps its *e.g.* italic markup, so the sentence now reads "…may or may not converge, e.g., depending on the initial guess."

   11. Line 181 (paper.md L107) — ✅ applied

   The package serves educational purposes through Tutorials.jl covering topics... → The package also serves educational purposes through Tutorials.jl, which covers topics...

   Applied; the hyperlink on Tutorials.jl is preserved.

   12. Line 190 (paper.md L109) — ✅ applied

   ...across the control-toolbox ecosystem packages → ...across the control-toolbox ecosystem

   ---

   The updated PDF is regenerated automatically by our Compile JOSS paper workflow and will be visible on the PR branch. Your other two issues (#803 and #805) are being handled separately.

   👍React with 👍1Reacted by Tangi Migot
3. ocots commented on Aug 1, 2026

   

   ocots

   on Aug 1, 2026

   Last edited by ocots

   Member

   More actions

   @tmigot Merged in #762.
4. ocots

   closed this as completedon Aug 1, 2026