Repository navigation
refactor(test): the GPU smoke test written once, status.jl split, coverage gaps (T4 of #449) - #477
Merged
Merged
Conversation
…erage gaps tested (T4 of #449) The two GPU smoke files were the same but for the backend: common/gpu_tests.jl, two wrappers; the GPU contract scans it too (TST6). status.jl keeps what is recorded during a run, the files written at its end move to status_reports.jl (same module). The show methods of the references and the discovery of the problems, uncovered on Codecov, are tested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
16 of 53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #449 (T4, the two items left open). Conventions: ct-conventions v0.14.0, ct-agents v0.5.0.
Summary
test/common/without duplicates, Share the GPU smoke test between OptimalControl and OptimalControlScalarized #445):test_smoke_optimalcontrol.jlandtest_smoke_scalarized.jlwere the same file but for the backend. Nowcommon/gpu_tests.jlholds the test once, and the two files are wrappers. The GPU contract (TST6: nobody asks CUDA butcommon/capabilities.jl) scans the shared file too. The lines of the report becometest_smoke_gpu …for both modelings (the modeling column tells them apart; nothing reads the former names).common/status.jl(615 lines): what is recorded during a run stays (draft test sets, rows, results, trajectories, the selection of the problems); the files written at the end of a run (reports, results, environments, trajectories) move tocommon/status_reports.jl, included in the same moduleTestStatus: no name changes.main: 92.3 %, 246 lines missed): 220 of them are the ModelingToolkit extension, which the coverage workflow does not run (opt-in environment; to add it, the coverage workflow of CTActions needs atest_argsinput, a separate change). Of the others, now tested: theshowmethods ofNumericalReferenceandAnalyticReference(11 lines), the discovery of the problems, run at precompilation (5 lines, now checked against the files). Left: two edge cases of the JuMP solution builder (a grid of one step, a solver without barrier iterations) and two one-line methods the report counts as missed after inlining.Test plan
coreandJuMP: passed (core 2347).run ci kkt-runnerruns them on the GPU runner.🤖 Generated with Claude Code