Repository navigation
Conversation
Integrators keep using quote.buyAmount (after network costs) as a generic toAmount next to other aggregators' before-gas amounts, so CoW ranks last even at an equal price. Add a "Displaying and Comparing Quotes" section, fix the quickstart to build the order from quoteResponse.quote, and link the amount-stage math on the concepts page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
raq0x
marked this pull request as draft
October 8, 2026 21:31
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Partners that integrate
/quotedirectly keep puttingquote.buyAmountinto their generictoAmount. Ambire did this most recently (fixed in AmbireTech/ambire-common#2779). For sell orders that value is after network costs and the protocol fee. Other aggregators usually return output before gas, and the user pays gas separately. As a result, comparison UIs rank CoW last even when its price is the same.The math is already on the How Intents Are Formed concepts page, but no other page links to it. The API guide says nothing about fees, and its quickstart spreads the whole quote response into the order.
Changes (
docs/cow-protocol/integrate/api.mdx)sellAmount,feeAmountandbuyAmountmean for a sell orderbuyAmount + buyAmount * feeAmount / sellAmount - partnerFee) for comparison with other aggregators, and the after-network-costs amount for after-gas rankingbeforeAllFees, because it also adds back the protocol fee and leaves out the partner feegetQuoteAmountsAndCosts/beforeNetworkCostsquoteResponse.quote. It signssellAmount + feeAmountwithfeeAmount: "0", reducesbuyAmountby slippage, and passesquoteIdandfrom. This matches "Forming the Final Order" on the concepts page.yarn buildpasses (onBrokenLinks/onBrokenAnchors: throw).🤖 Generated with Claude Code