Repository navigation
feat(solana-indexer) PR16: write created and traded order events - #4786
Merged
Merged
Conversation
…ill-state # Conflicts: # crates/solana-indexer/example.toml # crates/solana-indexer/src/config.rs # crates/solana-indexer/src/indexer/decoder/tests.rs # crates/solana-indexer/src/indexer/ingester.rs # crates/solana-indexer/src/run.rs
…5.6-adopt-cow-solana-rpc # Conflicts: # crates/solana-indexer/src/run.rs
…cle' into ilya/be-185-pr09-settlement-observation # Conflicts: # crates/autopilot-svm/src/tests.rs
…ot on the driver wire
…cle' into ilya/be-185-pr09-settlement-observation
…86-pr10-wiring-liveness-devnet-runbook # Conflicts: # Cargo.lock # crates/autopilot-svm/Cargo.toml
…cle' into ilya/be-185-pr09-settlement-observation
…86-pr10-wiring-liveness-devnet-runbook
…lement-observation # Conflicts: # crates/autopilot-svm/src/infra/executor.rs # crates/autopilot-svm/src/infra/mod.rs # crates/autopilot-svm/src/infra/observer.rs # crates/autopilot-svm/src/tests.rs
…86-pr10-wiring-liveness-devnet-runbook
…86-pr10-wiring-liveness-devnet-runbook
…olana-autopilot/be-232-order-events # Conflicts: # crates/autopilot-svm/src/infra/observer.rs # crates/autopilot-svm/src/run.rs # crates/autopilot-svm/src/tests.rs
…olana-autopilot/be-232-order-events # Conflicts: # crates/autopilot-svm/src/run.rs # crates/autopilot-svm/src/tests.rs
…olana-autopilot/be-232-order-events
…lement-observation
…86-pr10-wiring-liveness-devnet-runbook
…olana-autopilot/be-232-order-events
…er/be-242-order-events Keep the solana-owned OrderEventLabel from PR11 and cast against it.
squadgazzz
changed the base branch from
main
to
solana-autopilot/be-232-order-events
August 25, 2026 08:17
squadgazzz
marked this pull request as ready for review
August 25, 2026 09:26
Contributor
|
Claude finished @squadgazzz's task in 1m 55s —— View job PR Review: write created and traded order events
Verdict: Looks good. The design is sound: each event is gated on I left one minor, optional note inline. Nothing blocking. |
MartinquaXD
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The indexer now writes the order events for the flows it observes:
createdwhen it inserts asolana.ordersrow,tradedwhen it inserts asolana.tradesrow, each in the same transaction as the row itself. Therows_affectedgates keep replays idempotent, a conflicted insert writes no event. On EVM the components observing these flows write the same labels, on Solana that observer is the indexer.Neither write takes the advisory lock #4775 uses, because neither needs a dedup read: the gate is whether the row insert won its unique constraint, and Postgres serializes that already. The two writers stay clear of each other by owning disjoint labels,
createdandtradedhere againstready,executingandconsideredin the autopilot. A writer that takes a label from the other's set needs the lock too.Changes
createdandtradedorder events written atomically with theirorders/tradesrowsHow to test
Extended the batch-persistence Postgres test: exactly one event per inserted row, stable under replay.