Repository navigation
Send app_data through the solana auction - #4788
Closed
squadgazzz wants to merge 1 commit into
Closed
squadgazzz wants to merge 1 commit into
squadgazzz wants to merge 1 commit into
Conversation
Contributor
Author
|
in favor of #4780 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
app_datais an input to the on-chain intent hash, and that hash is the order uid and the order PDA seed. The settlement encoding in #4779 has to rebuild the exact intent, but the value stopped at the database: the indexer writessolana.orders.app_dataand nothing read it. This sends it through the auction so the driver can drop its zero placeholder.Stacked on #4787 (only for the trivial conflict in the db test helpers, retarget to main once it merges).
Changes
AppDatanewtype in chain-types,0x-hex on the wire like the uidapp_datainopen_ordersand carries it on the domain order/solverequest order gains anappDatafieldHow to test
Updated unit tests, the wire-format pin covers the new field. The driver ignores unknown fields, so this ships independently of #4779 consuming it.