Repository navigation
feat: Added $distinct parameter to SelectQuery::count - #242
Merged
Merged
Conversation
bbldn
force-pushed
the
feature/add-count-distinct
branch
from
February 28, 2026 22:27
4924eaf to
1c55d64
Compare
puzzledpolymath
approved these changes
Feb 28, 2026
roxblnfk
reviewed
Mar 2, 2026
| ); | ||
|
|
||
| $this->assertSame(4, $table->select()->count('DISTINCT(id)')); | ||
| $this->assertSame(4, $table->select()->count('id', true)); |
Member
There was a problem hiding this comment.
Please test it in a new function. The both cases should be covered
roxblnfk
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Why?
OrmIssues546