Repository navigation
deps: upgrade pnpm from 11.3.0 to 12.9.1 - #75
Merged
daniel-freiermuth merged 1 commit intoOct 5, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
The red Lint check is not caused by this PR.
I'm keeping the clippy fix out of this pnpm bump. It's a Rust test-code change that |
pnpm/action-setup v4 -> v6.1.0 (first tag with pnpm v12 support; the floating v6 tag still points at v6.0.10). pnpm 12 records the pinned packageManager in a leading env document of app/pnpm-lock.yaml.
daniel-freiermuth
force-pushed
the
improve/pnpm-major-update-11-3-0-12-9-1-4553
branch
from
October 5, 2026 17:49
d6bacda to
76b4823
Compare
daniel-freiermuth
marked this pull request as ready for review
October 5, 2026 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deps: upgrade pnpm from 11.3.0 to 12.9.1
What improved
pnpm moves from 11.3.0 to 12.9.1, the current
latestdist-tag, in CI, deploy, and thepackageManagerpin.Why it's worth doing
latest-11is 11.28.2), and v12 is nowlatest.pnpm-workspace.yamlsettings when the pinned version matches, so a misspelled setting can't be dropped silently. Release notes: https://github.com/pnpm/pnpm/releases/tag/v12.0.0What changed
.github/workflows/ci.yml(lint + test jobs) and.github/workflows/deploy.yml:pnpm/action-setup@v4→pnpm/action-setup@v6.1.0version: '11.3.0'→'12.9.1'@pnpm/exe.*optional dependencies, and action-setup only gained pnpm v12 support in v6.1.0 (feat: support pnpm v12 pnpm/action-setup#288). The floatingv6tag still points at v6.0.10 (git ls-remote:v6→ annotated tag object for commit0977fd9, which is the v6.0.10 commit;v6.1.0→ea17c68). A comment in the workflows records this.app/package.json:"packageManager": "pnpm@12.9.1".app/pnpm-lock.yaml: pnpm 12 adds a leading YAML document that records the pinned package manager (packageManagerDependencies: pnpm 12.9.1plus the integrity hashes of the@pnpm/exe.*platform binaries). The main lockfile document, starting atlockfileVersion: '9.0', is byte-for-byte unchanged, so no dependency was re-resolved.app/patches/@deck.gl__core.patch(viapatchedDependencies) still applies unchanged under pnpm 12.Verification (run locally with pnpm 12.9.1 from npm, Node 24.21.0)
cd app && rm -rf node_modules && pnpm install --frozen-lockfile: succeeded ("Done in 4.3s using pnpm v12.9.1"). The only lockfile change was the env document above. A second frozen install left the lockfile byte-identical (checked withcmp).node_modules/.pnpm/@deck.gl+core@9.4.0_patch_hash=8a96…/, and itsdist/dist.dev.jscontains the patchedfloat opacity;line.ERR_PNPM_UNRECOGNIZED_WORKSPACE_SETTINGS:allowBuildsandpatchedDependenciesare both accepted. The only warning was local (the store is on a different filesystem from this checkout); no deprecation warnings.wasm-pack build crates/core --target web --dev, then:pnpm exec svelte-check --tsconfig tsconfig.json: 0 errors, 0 warningspnpm exec eslint src: cleanpnpm test: 21 files / 207 tests passedpnpm run build: succeeded (PWA service worker generated)cd e2e && pnpm install --frozen-lockfile: succeeded withe2e/pnpm-lock.yamlunchanged (nopackageManagerpin there).pnpm store path --silent, whichactions/setup-node'scache: pnpmuses, works under pnpm 12.pnpm/action-setup@v6.1.0. The first CI run of this PR is the check for that.What I deliberately did NOT change
pnpm/action-setupto the exactv6.1.0tag. Once the floatingv6tag is moved to v6.1.0 or later, the threepnpm/action-setup@v6.1.0references (ci.ymllint and test jobs,deploy.yml) can go back to@v6if floating tags are preferred.packageManagertodevEngines.packageManager, and I did not adopt pnpm 12 opt-in features (globalShims,remoteSideEffectsCache).actions/checkout@v4,actions/setup-node@v4, Node22) are out of scope and unchanged.