Repository navigation
Enable safe Codex recovery on Windows - #904
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows Codex recovery currently cannot confirm that the previous provider process tree has stopped, so it blocks recovery after a failed resume or provider exit. Guard each Windows provider with a Job Object and keep the session fenced until its processes are confirmed stopped. The same fence covers cancellation, handoff, attachment, and replayed create requests.
Update the browser recovery fixture to return the specific missing-session error and assert the current notice disclosure.
The guard remains conservative if it cannot account for a process. Durable cleanup across a full Freshell server crash remains a separate pre-existing limitation.
Validation: