Repository navigation
Update mining docs: maintained p2pool-dash fork, its install guide, and current ASIC hardware - #587
Conversation
|
Warning Review limit reachedNext included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe mining documentation now references the maintained ChangesMining Documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/user/mining/index.rst`:
- Around line 135-136: Update the Bitmain Antminer D9 row in the mining hardware
table to use the unboxed dimensions 430 x 195.5 x 290 mm, or explicitly label
the existing 316 x 430 x 570 value as packaged dimensions; keep the net weight
unchanged.
In `@docs/user/mining/p2pool.rst`:
- Around line 22-24: Update the modern installation guidance in the surrounding
p2pool documentation to link to the maintained frstrtr/p2pool-dash README
instead of INSTALL.md until INSTALL.md is corrected. Also label the retained
python2 commands near the referenced installation steps as applicable only to
Ubuntu 20.04 and earlier, or replace them with the fork’s PyPy-based commands.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 0c8fb25a-e4af-4f5d-b2fb-2d221cde0f73
📒 Files selected for processing (3)
docs/user/mining/index.rstdocs/user/mining/p2pool.rstdocs/user/mining/pools.rst
…repo The install guide still cloned dashpay/p2pool-dash (unmaintained since May 2023) and pointed issues there. Point both at frstrtr/p2pool-dash so the modern install path is self-consistent with the fork and its README (flagged on dashpay/docs#587).
… label - Antminer D9: use unboxed dimensions 430 x 195.5 x 290 mm (was the packaged size reordered) so they are consistent with the 16.1 kg net weight; widen the Dimensions column to fit. - p2pool.rst: label the inline P2Pool setup as the legacy Python 2 procedure (Ubuntu 20.04 LTS and earlier); direct 24.04+ users to the fork PyPy INSTALL.md.
|
Thanks @coderabbitai — addressed both:
|
|
Tip For best results, initiate chat on the files or code changes.
The Antminer D9 dimensions now match the listed net weight. The P2Pool documentation now separates the legacy Python 2 procedure from the current PyPy-based installation path. 🐇 ✏️ Learnings added
You are interacting with an AI system. |
|
@PastaPastaPasta @UdjinM6 can you review these changes? |
|
pls consider UdjinM6@474535c |
The dashpay/p2pool-dash repository has not been updated since May 2023 and the setup procedure documented here depends on Python 2. The get-pip.py bootstrap it uses now refuses to run on Python 2.7 (min_version = (3, 10)), so these instructions cannot be completed on any current or older Ubuntu release, including 20.04. Rather than repointing readers at a specific community fork, remove the install and run procedure entirely and keep the page as background plus a maintenance notice. Community forks are mentioned as examples without endorsement, with a note that this software takes a payout address and requires RPC credentials for a Dash Core node. Also removes the four screenshots that only illustrated the deleted procedures, and updates the mining index and pools pages so they no longer present P2Pool as a supported setup path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KB7LtKLtr9EvstCTnWh1JZ
|
Thanks @thephez, @UdjinM6, and @PastaPastaPasta for the thoughtful review and refinement. Moving the legacy code to formal deprecation and clarifying the community status provides a much cleaner, safer path for the network. Mind that both p2pool-dash - do not require the wallet to be enabled in the Dash Core RPC and in c2pool-dash daemonless - it is even no need in dash core running. Miners just provide their payout addresses in the miner pool login field - and thats it! Payouts goes via coinbase TX, making all mined coins appears in the wallet as truly "mined" TX type. |
The two mining pages linked https://github.com/dashpay/p2pool-dash, which has not been updated since
30 May 2023 (Dash Core v0.12–v18 era, Python 2.7 only) and no longer works cleanly against current Dash Core.
This PR:
docs/user/mining/p2pool.rst,pools.rst,index.rst) tohttps://github.com/frstrtr/p2pool-dash — an actively maintained continuation supporting current Dash Core
(v23+, protocol 70238+), with variable difficulty, extranonce rolling, a persistent share/block archive,
and an updated dashboard. It runs on Python 2.7 via PyPy and ships an automated Ubuntu 24.04 installer.
INSTALL.mdfor modern Ubuntu/Debian, where Python 2 is no longer packaged.reimplementation whose Dash support is daemonless (no Dash Core node required) and, per that project's own
status table, still in development.
The change is a minimal, factual link correction plus one hedged note and one hardware row; the install
walkthroughs are otherwise unchanged so the diff is easy to review. Built locally with
make html— thethree edited pages render without errors.
Preview build: https://dash-docs--587.org.readthedocs.build/en/587/
Summary by CodeRabbit