Skip to content

Update mining docs: maintained p2pool-dash fork, its install guide, and current ASIC hardware - #587

Merged
thephez merged 7 commits into
dashpay:23.0.0from
frstrtr:docs-p2pool-maintained-fork
Sep 15, 2026
Merged

thephez merged 7 commits into
dashpay:23.0.0from
frstrtr:docs-p2pool-maintained-fork

Conversation

@frstrtr

@frstrtr frstrtr commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

The two mining pages linked https://github.com/dashpay/p2pool-dash, which has not been updated since
30 May 2023 (Dash Core v0.12–v18 era, Python 2.7 only) and no longer works cleanly against current Dash Core.

This PR:

  • Repoints the p2pool-dash links (docs/user/mining/p2pool.rst, pools.rst, index.rst) to
    https://github.com/frstrtr/p2pool-dash — an actively maintained continuation supporting current Dash Core
    (v23+, protocol 70238+), with variable difficulty, extranonce rolling, a persistent share/block archive,
    and an updated dashboard. It runs on Python 2.7 via PyPy and ships an automated Ubuntu 24.04 installer.
  • Points readers at the fork's INSTALL.md for modern Ubuntu/Debian, where Python 2 is no longer packaged.
  • Adds a short, hedged note about c2pool (https://github.com/frstrtr/c2pool), a from-scratch C++ P2Pool
    reimplementation whose Dash support is daemonless (no Dash Core node required) and, per that project's own
    status table, still in development.
  • Updates the X11 ASIC hardware table with the current Bitmain Antminer D9 (1770 GH/s, 2839 W).

The change is a minimal, factual link correction plus one hedged note and one hardware row; the install
walkthroughs are otherwise unchanged so the diff is easy to review. Built locally with make html — the
three edited pages render without errors.

Preview build: https://dash-docs--587.org.readthedocs.build/en/587/

Summary by CodeRabbit

  • Documentation
    • Updated P2Pool references to the actively maintained fork.
    • Added installation guidance for modern Ubuntu and Debian systems, including the PyPy-based setup guide.
    • Documented the legacy Python 2 procedure’s compatibility with Ubuntu 20.04 and earlier.
    • Mentioned an alternative mining pool option.
    • Noted that the original P2Pool repository is no longer actively updated.
    • Added the Bitmain Antminer D9 to the X11 ASIC miner table and improved table readability.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1ee71710-f9fe-49cf-a0c6-846e7170d3ca

📥 Commits

Reviewing files that changed from the base of the PR and between e8dc3bf and 587a678.

⛔ Files ignored due to path filters (4)
  • docs/user/mining/img/p2pool-antminer.png is excluded by !**/*.png
  • docs/user/mining/img/p2pool-dash-conf.png is excluded by !**/*.png
  • docs/user/mining/img/p2pool-ddwrt.png is excluded by !**/*.png
  • docs/user/mining/img/p2pool-running.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • docs/user/mining/index.rst
  • docs/user/mining/p2pool.rst
  • docs/user/mining/pools.rst
📝 Walkthrough

Walkthrough

The mining documentation now references the maintained frstrtr/p2pool-dash fork, updates installation guidance, and adds the Bitmain Antminer D9 to the ASIC miner table.

Changes

Mining Documentation

Layer / File(s) Summary
P2Pool fork references
docs/user/mining/index.rst, docs/user/mining/p2pool.rst, docs/user/mining/pools.rst
P2Pool links and setup instructions now use frstrtr/p2pool-dash. The documentation notes the original repository status, describes c2pool, and identifies legacy and modern installation procedures.
Antminer D9 listing
docs/user/mining/index.rst
The ASIC mining table now includes the Bitmain Antminer D9 specifications and a wider dimensions column.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main documentation changes: the maintained P2Pool fork, installation guidance, and updated ASIC hardware information.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/user/mining/index.rst`:
- Around line 135-136: Update the Bitmain Antminer D9 row in the mining hardware
table to use the unboxed dimensions 430 x 195.5 x 290 mm, or explicitly label
the existing 316 x 430 x 570 value as packaged dimensions; keep the net weight
unchanged.

In `@docs/user/mining/p2pool.rst`:
- Around line 22-24: Update the modern installation guidance in the surrounding
p2pool documentation to link to the maintained frstrtr/p2pool-dash README
instead of INSTALL.md until INSTALL.md is corrected. Also label the retained
python2 commands near the referenced installation steps as applicable only to
Ubuntu 20.04 and earlier, or replace them with the fork’s PyPy-based commands.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c8fb25a-e4af-4f5d-b2fb-2d221cde0f73

📥 Commits

Reviewing files that changed from the base of the PR and between 5b47c73 and 32b3f46.

📒 Files selected for processing (3)
  • docs/user/mining/index.rst
  • docs/user/mining/p2pool.rst
  • docs/user/mining/pools.rst

Comment thread docs/user/mining/index.rst Outdated
Comment thread docs/user/mining/p2pool.rst Outdated
frstrtr added a commit to frstrtr/p2pool-dash that referenced this pull request Aug 11, 2026
…repo

The install guide still cloned dashpay/p2pool-dash (unmaintained since May 2023)
and pointed issues there. Point both at frstrtr/p2pool-dash so the modern install
path is self-consistent with the fork and its README (flagged on dashpay/docs#587).
… label

- Antminer D9: use unboxed dimensions 430 x 195.5 x 290 mm (was the packaged
  size reordered) so they are consistent with the 16.1 kg net weight; widen the
  Dimensions column to fit.
- p2pool.rst: label the inline P2Pool setup as the legacy Python 2 procedure
  (Ubuntu 20.04 LTS and earlier); direct 24.04+ users to the fork PyPy INSTALL.md.
@frstrtr

frstrtr commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @coderabbitai — addressed both:

  1. Antminer D9 dimensions — replaced the packaged-size value with the unboxed dimensions `430 x 195.5 x 290 mm` so they are consistent with the listed net weight (16.1 kg); widened the Dimensions column to fit.
  2. Modern install path self-consistency — updated the fork's INSTALL.md to clone frstrtr/p2pool-dash (was still cloning the stale dashpay/p2pool-dash) and pointed its issues link to the fork. The inline P2Pool setup in p2pool.rst is now explicitly labelled as the legacy Python 2 procedure (Ubuntu 20.04 LTS and earlier), with 24.04+ users directed to the fork's PyPy-based INSTALL.md.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@frstrtr Thank you. The changes address both findings.

The Antminer D9 dimensions now match the listed net weight. The P2Pool documentation now separates the legacy Python 2 procedure from the current PyPy-based installation path.

🐇


✏️ Learnings added
Learnt from: frstrtr
URL: https://github.com/dashpay/docs/pull/587

Timestamp: 2026-08-11T07:28:00.743Z
Learning: In the Dash mining documentation, the inline procedure in `docs/user/mining/p2pool.rst` is the legacy Python 2 procedure for Ubuntu 20.04 LTS and earlier. For Ubuntu 24.04 and later, direct users to `frstrtr/p2pool-dash` `INSTALL.md`, which contains the current PyPy-based installation procedure.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

You are interacting with an AI system.

@thephez

thephez commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

@PastaPastaPasta @UdjinM6 can you review these changes?

@UdjinM6

UdjinM6 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

pls consider UdjinM6@474535c

The dashpay/p2pool-dash repository has not been updated since May 2023
and the setup procedure documented here depends on Python 2. The
get-pip.py bootstrap it uses now refuses to run on Python 2.7
(min_version = (3, 10)), so these instructions cannot be completed on
any current or older Ubuntu release, including 20.04.

Rather than repointing readers at a specific community fork, remove the
install and run procedure entirely and keep the page as background plus
a maintenance notice. Community forks are mentioned as examples without
endorsement, with a note that this software takes a payout address and
requires RPC credentials for a Dash Core node.

Also removes the four screenshots that only illustrated the deleted
procedures, and updates the mining index and pools pages so they no
longer present P2Pool as a supported setup path.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KB7LtKLtr9EvstCTnWh1JZ
@thephez
thephez merged commit c732b31 into dashpay:23.0.0 Sep 15, 2026
1 check passed
@frstrtr

frstrtr commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @thephez, @UdjinM6, and @PastaPastaPasta for the thoughtful review and refinement. Moving the legacy code to formal deprecation and clarifying the community status provides a much cleaner, safer path for the network. Mind that both p2pool-dash - do not require the wallet to be enabled in the Dash Core RPC and in c2pool-dash daemonless - it is even no need in dash core running. Miners just provide their payout addresses in the miner pool login field - and thats it! Payouts goes via coinbase TX, making all mined coins appears in the wallet as truly "mined" TX type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants