Repository navigation
bug(data-weaver): Move multi-selection UI to OnTheCanvas slot - #451
Merged
Merged
Conversation
Move the multi-selection selection UI and its hooks/styles from InFrontOfTheCanvas into a new OnTheCanvas component. Added on_the_canvas index.module.scss and OnTheCanvas index.tsx which renders Selection only when multiple shapes are selected. Renamed selection files (selection.tsx, use_selection_* and styles) into the on_the_canvas folder and removed Selection from InFrontOfTheCanvas. Updated atlas config to register OnTheCanvas and adjusted overlay comment to reference the new slot.
pablonoel
marked this pull request as ready for review
August 25, 2026 20:02
pablonoel
requested review from
beets,
miss-o-soup and
nick-nlb
as code owners
August 25, 2026 20:02
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves the custom multi-selection UI from the InFrontOfTheCanvas component to a new OnTheCanvas component, which is conditionally rendered when multiple shapes are selected. The configuration and comments have been updated accordingly to register and reference the new component. There are no review comments, and we have no additional feedback to provide.
pablonoel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone of: #430
The multi-card selection bounding box (the blue border + action toolbar shown when 2+ cards are selected) was rendering above the prompt input and other page-level UI. This happened because the selection lived inside the InFrontOfTheCanvas portal, which uses z-index: $z-index-overlay (2) — above the prompt's z-index: $z-index-above-content (1).
Fixed by extracting the selection into its own OnTheCanvas tldraw component slot, rendered via a separate portal at z-index: $z-index-content (0) — the same stacking level as the cards themselves.
Changes Made
Testing Done
Describe the steps you took to test these changes (please also list commands ran if possible).
Checklist
Note: Only Maintainers can approve and merge PRs. Expected initial review time: 3 business days.