Repository navigation
Conversation
Coverage reportfor commit: WARNING: Unable to compute coverage delta information. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #418.
What changed
codecov_aggregator.ymlnow also triggers onmerge_group.main_it, tests against the shared Astra DB) runs only onmerge_group— no longer on every PR push (or push tomain).aggregatecoverage job now toleratesmain_itbeing skipped, so per-PR coverage still runs from the local integration and unit jobs.main.ymlgets aconcurrencygroup (astra-integration-shared-db, no cancel) so two Astra runs can never hit the shared database at the same time, even outside the queue.Unit tests and the local Data API integration job are unchanged and still run on every PR.
Still needed in repo settings (not in this diff)
A workflow change alone cannot turn on the merge queue. Before or with merging this PR, a repo admin needs to:
main.main_it / testso a failing Astra run blocks merging.Please enable the queue before merging: until then, the Astra job will not run anywhere (it no longer runs on PRs or pushes to
main).Note: pushes to
mainno longer run the Astra job, so the storedmaincoverage baseline comes from the local integration job. It runs the sametests/base/integrationsuite against a local Data API, so coverage should be effectively unchanged.Verification
actionlinton both workflows: 7 findings before this change, 7 after — all pre-existing (old action versions, shellcheck notes); none on the new lines.merge_grouppath itself can only be exercised once the queue is enabled and a PR is queued.