Repository navigation
Conversation
Root AGENTS.md, the governance document, and the Copilot/CodeRabbit review configuration now recognize an optional AGENTS.md inside each source/source_xxx/ module directory. Module-level files refine the root baseline and never override it. Add source/source_esolver/AGENTS.md as the first such file: it states the esolver cockpit-dashboard constraint and two checkable rules -- orchestrate the algorithm flow only, and reuse the shared cross-solver naming. .coderabbit.yaml loads nested AGENTS.md through a new "**/AGENTS.md" knowledge-base pattern.
mohanchen
added
Machine Learning & AI
|
@ABACUS-PR-BOT please review the PR |
ABACUS-PR-BOT
left a comment
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Static review of b7af2921: no blocking issues found in this docs/config-only change. git diff --check passed; the governance checker pinned at e9d04303 reported one metadata warning and no errors. No builds or runtime tests were run; CI status was unavailable through the required connector.
Non-blocking: Please fill the verification section with the static commands/results actually run and a docs/config-only reason for skipping runtime tests, add the issue or no-issue rationale, and replace the remaining template placeholders. The opening prose already describes the change.
Address the review note on PR deepmodeling#8148: the owning-module examples now use the directory names registered in source/CMakeLists.txt (source_estate, source_hamilt) instead of the legacy module_elecstate/module_hamilt names, so the guidance is directly searchable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The rule 1 example listed "relaxation steps" as an esolver responsibility, but the outer ionic loop is owned by the calling drivers: Relax_Driver::relax_driver() and the MD driver invoke ESolver::runner() once per ionic step. State that esolver orchestrates the flow within one ionic step and point to source_relax/source_md as the owners of the outer loop. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ABACUS-PR-BOT
left a comment
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Static incremental review of 9d86080d: the corrected module names and outer ionic-loop ownership match the current code. git diff --check passed; the trusted governance checker reported no errors and the previously noted metadata warning. No builds or runtime tests were run.
| hood" in their owning modules. | ||
|
|
||
| 1. `esolver` functions only orchestrate the algorithm flow within one ionic | ||
| step (e.g., the SCF iteration); the outer ionic loop lives in the calling |
There was a problem hiding this comment.
Non-blocking: Could the one-ionic-step restriction name runner() explicitly and retain the run-wide setup/finalization hooks? Driver::driver_run() calls before_all_runners() and after_all_runners() outside the MD/relax loops, so the current wording also covers legitimate lifecycle orchestration. This clarification can follow up after merge.
Root AGENTS.md, the governance document, and the Copilot/CodeRabbit review configuration now recognize an optional AGENTS.md inside each source/source_xxx/ module directory. Module-level files refine the root baseline and never override it.
Add source/source_esolver/AGENTS.md as the first such file: it states the esolver cockpit-dashboard constraint and two checkable rules -- orchestrate the algorithm flow only, and reuse the shared cross-solver naming.
.coderabbit.yaml loads nested AGENTS.md through a new "**/AGENTS.md" knowledge-base pattern.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
Fix #
Unit Tests and/or Case Tests for my changes
What's changed?
Governance Notes