Repository navigation
Conversation
Growl1234
added
Refactor
Growl1234
changed the title
ZhouXY-PKU
reviewed
Oct 22, 2026
| // calculate the sizes needed for pre-allocated buffer. | ||
| CHECK_CUSOLVER(cusolverDnDsygvd_bufferSize(cusolver_H, CUSOLVER_EIG_TYPE_1, CUSOLVER_EIG_MODE_VECTOR, uplo, n, | ||
| A, lda, B, ldb, W, &lwork)); | ||
| CHECK_CUSOLVER(cusolverDnDsygvd_bufferSize(cusolver_H, |
| const int j = band * ld + i; | ||
| out[j] = direction ? x[j] + a[band] * (out[j] - b[band] * y[j]) : (out[j] + a[band] * x[j]) + b[band] * y[j]; | ||
| out[j] | ||
| = direction ? x[j] + a[band] * (out[j] - b[band] * y[j]) : (out[j] + a[band] * x[j]) + b[band] * y[j]; |
Collaborator
Author
There was a problem hiding this comment.
Honestly I don't like this either, but clang-format choose what it thinks proper :(
| psi_iter + (nbase + m) * dim, | ||
| psi_m_norm); | ||
| if (psi_norm) { | ||
| ModuleBase::vector_div_constant_op<T, base_device::DEVICE_CPU>()(dim, |
| return std::make_pair(info, std::vector<int>{}); | ||
| } else if (info < 0) { | ||
| } | ||
| else if (info < 0) |
Collaborator
Author
There was a problem hiding this comment.
Changing style to LLVM will avoid such addition, but that was not accepted and then dropped in my first precommit PR.
| else | ||
| { | ||
| work_.dot_pair(ld_, dim_, active_, residual, residual, work_.data(shadow_slot), residual, norm_.data(), rho_.data()); | ||
| work_.dot_pair(ld_, |
| const Wide one(1); | ||
| const Wide zero(0); | ||
| ModuleBase::gemm_op<Wide, base_device::DEVICE_CPU>()('N', 'N', n, n, n, &one, a.data(), n, b.data(), n, &zero, result->data(), n); | ||
| ModuleBase::gemm_op<Wide, base_device::DEVICE_CPU>()('N', |
ABACUS-PR-BOT
left a comment
ABACUS-PR-BOT
left a comment
Collaborator
There was a problem hiding this comment.
Non-blocking: Please replace the template placeholders with a brief formatting/include-order summary and the exact verification commands and results. If builds or runtime tests were not run, state that and why, and note why INPUT documentation is unchanged. This reformat does not by itself require new functional tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
Fix #
Unit Tests and/or Case Tests for my changes
What's changed?
Governance Notes