Repository navigation
CPROVER library: __builtin_X falls back to the model of X - #9434
Open
tautschnig wants to merge 1 commit into
Open
tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
tautschnig
requested review from
kroening,
peterschrammel and
remi-delmas-3000
as code owners
November 10, 2026 19:06
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
GCC and Clang provide __builtin_X for the C library functions X with X's meaning (GCC manual, "Other Built-in Functions Provided by GCC"). The library modelled only a few of them (__builtin_fabs, ...); libc++'s <cmath> calls __builtin_ceilf, __builtin_sqrt, ... and those had no body. get_cprover_library_text now gives a requested __builtin_X without a model of its own the model of X, with X renamed (as a whole word, outside #include lines). Models taking a va_list are not reused: where va_list is a struct (aarch64), the model's parameter type differs from the __builtin_va_list of a declaration, and linking left the model's va_list typedef unresolved. New test cbmc/gcc_builtin_library_functions (also for __builtin_strcmp, __builtin_strlen and __builtin_memcmp, which thus need no model of their own). Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
force-pushed
the
pr/c-builtin-fallback-to-model
branch
from
November 10, 2026 20:17
2c4e896 to
25ef6df
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9434 +/- ##
========================================
Coverage 81.02% 81.03%
========================================
Files 1723 1723
Lines 191314 191366 +52
Branches 73 73
========================================
+ Hits 155020 155070 +50
- Misses 36294 36296 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC and Clang provide __builtin_X for the C library functions X with X's meaning (GCC manual, "Other Built-in Functions Provided by GCC"). The library modelled only a few of them (__builtin_fabs, ...); libc++'s calls __builtin_ceilf, __builtin_sqrt, ... and those had no body. get_cprover_library_text now gives a requested __builtin_X without a model of its own the model of X, with X renamed (as a whole word, outside #include lines). Models taking a va_list are not reused: where va_list is a struct (aarch64), the model's parameter type differs from the __builtin_va_list of a declaration, and linking left the model's va_list typedef unresolved.
New test cbmc/gcc_builtin_library_functions.