Repository navigation
feat: 🚧 authored twin layer with quote verification - #5176
Merged
sorensensig merged 4 commits intoAug 17, 2026
Merged
sorensensig merged 4 commits into
sorensensig merged 4 commits into
Conversation
|
This was referenced Aug 13, 2026
sorensensig
marked this pull request as ready for review
August 17, 2026 10:17
sorensensig
requested review from
Barsnes,
eirikbacker and
mimarz
as code owners
August 17, 2026 10:17
Adds the rules that exist only as documentation prose to the twins: accessibility requirements, relations and composition rules for 44 components, each backed by a verbatim quote from designsystemet.no, plus three pattern twins (form validation, required/optional marking, field guidance) that the generator now copies into the registry and inverts into component twins. pnpm merge:twins fetches every cited page and verifies each quote still appears there. A quote that fails drops the component's reviewed status and lands on registry/REVIEW.md, so documentation changes surface on the next run instead of going silently stale. reviewedAgainst in the data records the package version of the human sign-off. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review findings: two of three pattern files keyed components by capitalized name while the generator matches directory slugs, silently emptying the pattern backlinks on five component twins (verified restored for all). Dangling $schema and links.md pointers removed (targets do not exist here), generator metadata reduced to 'authored', and one boundaries sentence referencing an internal brief pruned. merge script gets the same absolute-path fix as the generator. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sorensensig
force-pushed
the
feat/ai-twin-authored-layer
branch
from
August 17, 2026 11:01
b6e35c5 to
6c1c2c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second PR of the stack proposed in #5166 (AI-readiness), stacked on #5167. It adds:
scripts/twins-authored.json: the rules that exist only as documentation prose (accessibility, relations, composition) for 44 components, each backed by a verbatim quote from designsystemet.noscripts/twin-patterns/(form validation, required/optional marking, field guidance), which the generator now copies into the registry and inverts, so every component twin lists the patterns that govern itscripts/merge-authored-twins.mjsand apnpm merge:twinsscript: fetches every cited docs page and verifies each quote still appears thereregistry/REVIEW.md, so documentation changes surface on the next run instead of going silently stalereviewedAgainstin the data file records which package version a human sign-off was made against (currently 1.18.0 for all 44 components)Running the pipeline today: 40 of 44 components fully verified and reviewed; 4 rules land on the review sheet because the documentation was reworded after the sign-off. That is the drift mechanism working, not a defect.
In this design the documentation prose is canonical and every rule cites it. #5166 notes a possible longer-term inversion under "Possible extensions": rules maintained as structured data from which both the human documentation and this AI layer are generated.
🚧 Draft on purpose: stacked on #5167 (GitHub cannot base a fork PR on another fork branch, so this branch contains #5167's commits; the diff specific to this PR starts at the authored layer). Not ready for merge until the stack's shape is agreed on #5166.
Checks
pnpm changesetif relevant): not relevant, repo scripts and data only🤖 Generated with Claude Code