maniphest create --parent creates a task as a subtask - #546
Merged
Merged
Conversation
maniphest create had no way to make a subtask; only a create spec could, with parent: T123. --parent takes a task monogram or PHID, repeatable and comma-separated like --tag and --attach, and is sent as parents.add in the maniphest.edit that creates the task - the transaction a spec uses - so the parent is not edited and keeps its subtasks. Every parent is resolved first by resolve_task_phids, in at most two maniphest.search calls, so an unknown parent is refused and nothing is created. The dry run names them, and --with refuses --parent like the other options a spec ignores. Closes #545 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
holmboe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maniphest createhad no way to make a subtask. Only a create spec could, withparent: T123.--parenttakes a task monogram or PHID, repeatable and comma-separated like--tagand--attachparents.addin the samemaniphest.editthat creates the task, which is the transaction a spec uses. The parent is not edited and keeps its subtasksresolve_task_phids, in at most twomaniphest.searchcalls, so an unknown parent is refused and nothing is created--dry-runnames the parents, and--withrefuses--parentlike the other options a spec ignoresTesting
uv run pytestpasses (5800 tests), and ruff and mypy are cleanParents: T81,--dry-runnames the parent, and--parent=T999999exits 1 without creating anythingCloses #545
🤖 Generated with Claude Code