Repository navigation
added fit configuration owner #427 - #429
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #429 +/- ##
===========================================
+ Coverage 95.05% 95.13% +0.08%
===========================================
Files 55 56 +1
Lines 6006 6249 +243
===========================================
+ Hits 5709 5945 +236
- Misses 297 304 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how fit configuration is managed in the project, centralizing all minimizer and fitting settings into a new
FitSettingsclass.Fit Configuration Refactor and Centralization:
FitSettingsclass infit_settings.pyto encapsulate all minimizer selection and configuration, including validation, serialization, and method-specific options.Projectto store and use a singleFitSettingsinstance (self._fit_settings) instead of separate minimizer fields. All access to minimizer and fit options now go through this object.fit_settingsinProject, ensuring any changes are validated and applied to the next fit.minimizerproperty and setter inProjectto delegate tofit_settings, simplifying the interface and ensuring consistency.Project Serialization/Deserialization:
fit_settings(with legacy support forfitter_minimizer), and updated loading to useFitSettings.from_dict, collecting any warnings for the user.DEFAULT_MINIMIZERdefinition fromproject.pyand re-exported it fromfit_settings.pyfor compatibility.Public API and Fit Preparation:
prepare_fitmethod toProjectthat prepares a fit using a snapshot of the currentfit_settings, supporting advanced workflows and ensuring reproducibility.