Skip to content

Preserve test coverage in Go 1.24 fixture refresh - #1

Merged
elukey merged 1 commit into
elukey:masterfrom
ang-cloudflare:fix-pr-1434-review-findings
Sep 18, 2026
Merged

elukey merged 1 commit into
elukey:masterfrom
ang-cloudflare:fix-pr-1434-review-findings

Conversation

@ang-cloudflare

Copy link
Copy Markdown

Summary

  • replace skipped live-network bundler cases with hermetic local TLS coverage for success, SNI, certificate errors, and dial errors
  • preserve SHA-1 warning and chain-selection coverage below the Go 1.24 verifier boundary while retaining capability-gated integration on older Go
  • strengthen JSON bundle identity assertions and the SHA-2 homogeneity ordering regression
  • make fixture generation fail cleanly when SHA-1 is unavailable, align pathlen:0 across generation paths, and remove persistent serial sidecars

Context

This is a follow-up to cloudflare#1434 and addresses the findings from review 5226026523. It targets the contributor branch so it can be merged directly into the original PR.

Verification

  • go test -count=1 ./bundler ./ubiquity ./api/...
  • go test -race -count=1 ./bundler
  • go test -count=20 ./bundler
  • GOTOOLCHAIN=go1.23.12 GODEBUG=x509sha1=1 go test -count=1 ./bundler -run "^(TestChromeWarning|TestSHA2Preferences)$" -v
  • bash -n and shellcheck for all three generation scripts
  • disposable successful and SHA-1-blocked generator runs
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants