Repository navigation
Preserve test coverage in Go 1.24 fixture refresh - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathlen:0across generation paths, and remove persistent serial sidecarsContext
This is a follow-up to cloudflare#1434 and addresses the findings from review 5226026523. It targets the contributor branch so it can be merged directly into the original PR.
Verification
go test -count=1 ./bundler ./ubiquity ./api/...go test -race -count=1 ./bundlergo test -count=20 ./bundlerGOTOOLCHAIN=go1.23.12 GODEBUG=x509sha1=1 go test -count=1 ./bundler -run "^(TestChromeWarning|TestSHA2Preferences)$" -vbash -nandshellcheckfor all three generation scriptsgit diff --check