Skip to content

Adding a fourth canonical exercise to the 'resistor color' series - #2682

Merged
glennj merged 12 commits into
exercism:mainfrom
Cool-Katt:main
Oct 17, 2026
Merged

glennj merged 12 commits into
exercism:mainfrom
Cool-Katt:main

Conversation

@Cool-Katt

Copy link
Copy Markdown
Contributor

No description provided.

@Cool-Katt
Cool-Katt requested a review from a team as a code owner September 8, 2026 11:24
@Cool-Katt

Copy link
Copy Markdown
Contributor Author

Okay, so
This is a port of the fourth exercise in the 'resistor colours' series, taken pretty much as is from the Python track.
Discussion can be found here


After many attempts, every check except for the links passes. I don't think I can do much about the links in this PR and it's out of scope so it should be fine™️

Comment thread exercises/resistor-color-tolerance/description.md
Comment thread exercises/resistor-color-tolerance/canonical-data.json
Comment thread exercises/resistor-color-expert/metadata.toml Outdated
Comment thread exercises/resistor-color-tolerance/metadata.toml Outdated
Comment thread exercises/resistor-color-tolerance/description.md
@glennj

glennj commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Resistors are nightmare fuel for the colourblind.

Comment thread exercises/resistor-color-tolerance/description.md Outdated

@kotp kotp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but provided suggestion that could be put in place, in agreement with @IsaacG .

Comment thread exercises/resistor-color-tolerance/description.md Outdated
Comment thread exercises/resistor-color-tolerance/description.md Outdated
Comment thread exercises/resistor-color-tolerance/metadata.toml Outdated

@zeektvbox01-hub zeektvbox01-hub left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to add a mention of decimal values

@glennj

glennj commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

@Cool-Katt where do you stand with this? Just a couple of suggested changes. The link checker stuff will probably self-resolve if you rebase.

Cool-Katt and others added 3 commits October 16, 2026 22:50
Co-authored-by: Victor Goff <keeperotphones@gmail.com>
Co-authored-by: Victor Goff <keeperotphones@gmail.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
@Cool-Katt

Copy link
Copy Markdown
Contributor Author

@glennj
Fuck, I'm sorry, I put this stuff on the back-burner and I wanted to take a deeper look at how translations work and I ended up just forgetting....

I'm good with all the suggestions, and I don't really care about the link checker, so If you want to merge this i'm good.

@glennj

glennj commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Well, there's the style guide bully, and I think the i18n error is occurring org-wide.

@Cool-Katt

Copy link
Copy Markdown
Contributor Author

The way I understood, the i18n error would resolve by putting a ready-to-translate label on this pr when it's ready to translate, hopefully? Do we do that for problem-spec prs too, is it for every pr from now on?

@glennj

glennj commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Every PR that touches docs.

exercism-i18n Bot added a commit to exercism/i18n that referenced this pull request Oct 16, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@exercism-i18n

exercism-i18n Bot commented Oct 16, 2026

Copy link
Copy Markdown

This PR has been translated 🚀

@glennj

glennj commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

@Cool-Katt the CI failure is not a link checker, its the markdown linter. It will keep failing for subsequent PRs until fixed.

https://github.com/exercism/problem-specifications/actions/runs/38957960230/job/117165491655?pr=2682#step:6:229

Comment thread exercises/resistor-color-tolerance/description.md Outdated
Comment thread exercises/resistor-color-tolerance/description.md Outdated
@IsaacG

IsaacG commented Oct 16, 2026

Copy link
Copy Markdown
Member

@Cool-Katt the CI failure is not a link checker, its the markdown linter. It will keep failing for subsequent PRs until fixed.

https://github.com/exercism/problem-specifications/actions/runs/38957960230/job/117165491655?pr=2682#step:6:229

I added "suggestions" to fix the linter

Cool-Katt and others added 2 commits October 17, 2026 00:16
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
@github-actions github-actions Bot removed the ready-to-translate The English in this PR is final; queue its translations label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This push changed English, so ready-to-translate has come off and any queued translation is withdrawn.

A maintainer: please re-apply ready-to-translate once the copy is final. That queues the translation at the PR's head commit.

@Cool-Katt

Copy link
Copy Markdown
Contributor Author

Okay, @IsaacG thanks for the suggestions. I ended up having to rerun the lint & format properly (so having to turn my computer on just for that, annoying) but it's now fine, except for the translation.

@glennj I won't re-apply the ready-to-translate label immediately, just in case we need any last 'last minute' changes, so let's let it sit for the weekend and merge next week, if noone has anything to say. Thanks for your help.

@IsaacG

IsaacG commented Oct 16, 2026

Copy link
Copy Markdown
Member

We have 6 approvals and the other checks pass. I'll use some of my monthly Exercism donations to fund another translation and get that done 😁

@IsaacG IsaacG added x:action/create Work on something from scratch x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) ready-to-translate The English in this PR is final; queue its translations labels Oct 16, 2026
exercism-i18n Bot added a commit to exercism/i18n that referenced this pull request Oct 16, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@exercism-i18n

exercism-i18n Bot commented Oct 16, 2026

Copy link
Copy Markdown

This PR has been translated 🚀

@glennj
glennj merged commit dc0574a into exercism:main Oct 17, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-translate The English in this PR is final; queue its translations x:action/create Work on something from scratch x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants