Repository navigation
Adding a fourth canonical exercise to the 'resistor color' series - #2682
Conversation
|
Okay, so After many attempts, every check except for the links passes. I don't think I can do much about the links in this PR and it's out of scope so it should be fine™️ |
|
Resistors are nightmare fuel for the colourblind. |
zeektvbox01-hub
left a comment
There was a problem hiding this comment.
Try to add a mention of decimal values
|
@Cool-Katt where do you stand with this? Just a couple of suggested changes. The link checker stuff will probably self-resolve if you rebase. |
Co-authored-by: Victor Goff <keeperotphones@gmail.com>
Co-authored-by: Victor Goff <keeperotphones@gmail.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
|
@glennj I'm good with all the suggestions, and I don't really care about the link checker, so If you want to merge this i'm good. |
|
Well, there's the style guide bully, and I think the i18n error is occurring org-wide. |
|
The way I understood, the i18n error would resolve by putting a |
|
Every PR that touches docs. |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This PR has been translated 🚀 |
|
@Cool-Katt the CI failure is not a link checker, its the markdown linter. It will keep failing for subsequent PRs until fixed. |
I added "suggestions" to fix the linter |
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
|
This push changed English, so A maintainer: please re-apply |
|
Okay, @IsaacG thanks for the suggestions. I ended up having to rerun the lint & format properly (so having to turn my computer on just for that, annoying) but it's now fine, except for the translation. @glennj I won't re-apply the |
|
We have 6 approvals and the other checks pass. I'll use some of my monthly Exercism donations to fund another translation and get that done 😁 |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This PR has been translated 🚀 |
No description provided.