Repository navigation
[resistor-color-tolerance] Correct tolerance in expected output: grey is 0.05% tolerance - #2692
Merged
Merged
Conversation
BNAndras
approved these changes
Oct 19, 2026
Member
Author
|
Do I need to create a new test? |
Member
|
Yeah, reimplement the bad one with the correct value. |
IsaacG
force-pushed
the
resistor-color-tolerance.grey
branch
from
October 19, 2026 00:22
d76b8fb to
bbc3833
Compare
… is 0.05% tolerance
IsaacG
force-pushed
the
resistor-color-tolerance.grey
branch
from
October 19, 2026 00:24
bbc3833 to
7a86bcd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Cool-Katt
requested changes
Oct 19, 2026
Cool-Katt
left a comment
Cool-Katt
left a comment
Contributor
There was a problem hiding this comment.
There should be a reimplements field with the UUID of the old test, otherwise both tests are valid.
Man, it's too early in the morning...
Member
Author
Thanks for catching that! Updated. |
Cool-Katt
approved these changes
Oct 19, 2026
Contributor
Now Only the CI left, and one more approval |
glennj
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.