Repository navigation
Refuse to delete a principal who owns a credential - #217
Merged
alexanderguy merged 2 commits intoOct 8, 2026
Merged
alexanderguy merged 2 commits into
alexanderguy merged 2 commits into
Conversation
Member
Author
|
Self-review ( |
alexanderguy
deleted the
intr-494-deleting-a-principal-silently-converts-their-personal
branch
October 8, 2026 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ON DELETE RESTRICT. Null remains the tenant-owned marker, and the credential stays bound to its principal until the credential row itself is deleted.DELETE /api/tenants/:tenantId/principals/:principalIdreturns 409Principal is still referencedwhen a foreign key still points at the principal. A principal with no such reference is removed, and a tenant-owned credential stays tenant-owned.Verification
gmake allexits 0 on this branch: 933 pass, 2 skip, 0 fail. The two skips are the live Google GenAI tests.origin/main.Closes INTR-494