Repository navigation
Conversation
…n list The API accepts a like on any post type, but only comments have text. The notification's excerpt then threw, and the whole notification list rendered nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4108
Changes proposed in this pull request:
The API accepts a like on any post type, but only comment posts have text. When someone likes, say, a "discussion renamed" post, the author's liked notification throws while building its excerpt, and the author's whole notification list renders nothing, other notifications included. The excerpt now falls back to an empty string, as the mentions notification already does. #4108 stays open for the extensible "can this post type notify" design.
Reviewers should focus on:
Screenshot
N/A
Necessity
Confirmed
yarn testinjs/).composer test). (No backend changes.)