Repository navigation
chore(release): pending release v0.98.4 - #1376
Merged
Merged
Conversation
…#1325) Co-authored-by: fro-bot[bot] <109017866+fro-bot[bot]@users.noreply.github.com>
Co-authored-by: fro-bot[bot] <109017866+fro-bot[bot]@users.noreply.github.com>
Co-authored-by: fro-bot[bot] <109017866+fro-bot[bot]@users.noreply.github.com>
Co-authored-by: fro-bot[bot] <109017866+fro-bot[bot]@users.noreply.github.com>
Co-authored-by: fro-bot[bot] <109017866+fro-bot[bot]@users.noreply.github.com>
Co-authored-by: fro-bot[bot] <109017866+fro-bot[bot]@users.noreply.github.com>
The Actions cache cannot persist session state on the mention flows: GitHub issues read-only cache tokens for issue_comment and issues runs, so every mention started cold. #1370 and #1373 made that failure visible and fixed the restore ordering, but neither restores continuity on its own -- the action still had no durable store to fall back to. Credentials go in job env rather than action inputs because the S3 adapter resolves through the ambient AWS SDK chain; parseActionInputs never populates storeConfig.credentials. filterAgentEnv denies AWS_* from the agent child, so the harness holds them and the model's bash never sees them. s3-sse-encryption is set explicitly. Left unset, getEffectiveEncryption returns aws:kms on real AWS, which would require KMS grants the session-state policy deliberately does not have. The bucket is SSE-S3.
…orage (#1383) An IAM policy was derived from how the save path behaves — keys come from a fixed filename set, so nothing needs to list. The restore path lists before it downloads. A denied list is not an error: it returns a handled miss, the run stays green, and every session starts cold forever. The repo's own README had documented the missing permission all along. Verifying that claim reproduced it. A text pattern of the shape `new [A-Za-z]+Command\(` cannot match ListObjectsV2Command, and a structural sweep scoped to two directories undercounted call sites by four. Both errors are the same error the doc is about. Separately, a PR stayed blocked after the bot replied that no blockers remained. The verdict was right and undeliverable: response surface is keyed off the triggering event, so a mention can only ever comment, and the reconciliation backstop no-ops on the same distinction. That is a security boundary — a comment-triggered run must not be able to unblock a PR — not a gap to close.
Co-authored-by: fro-bot[bot] <109017866+fro-bot[bot]@users.noreply.github.com>
Co-authored-by: fro-bot[bot] <109017866+fro-bot[bot]@users.noreply.github.com>
Co-authored-by: fro-bot[bot] <109017866+fro-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending Release: v0.98.4
Merge this PR with a merge commit to trigger a release.
Commits Since Last Release
Auto-generated by the release pipeline. Updated: 2026-08-12 20:28 UTC